From nobody Tue Apr 28 18:21:26 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4pfr05dXz6btYP for ; Tue, 28 Apr 2026 18:21:40 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4pfq4zWBz3rCr for ; Tue, 28 Apr 2026 18:21:39 +0000 (UTC) (envelope-from ctuffli@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82d0b68837aso6999908b3a.2 for ; Tue, 28 Apr 2026 11:21:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777400498; x=1778005298; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ocBzdZ9ebM2qkPhKCYwPV67/2QPQ4oB2BBkDMWmRt5o=; b=BuWeHSlpkywqf3v4yRVSPaOZMLoCi9uOHkOwjpTz7oPNygEDCbvj0nC9MVM+CxMy6A QsPGIoc4LvpQSD7cH3R2VjMLY6JQ0UR1d6ts4xcVquTLW9J3pcrRl9Rq0cgQ7iCZf6Uz AHGt0vrOlAC6LSXlxTWN9+slTDmwoHFK05EYdjMnfKJTryO0HQswkMPRdaDXgCLhk0Ns +77QkKTPSKt1Cm1RRqtrTvic8q9w7hHh1aCRDvI+KsXpe+ZRIfmvNtKhKzxM+140syym LoIfTwrIRu/hxxFkrsrPdv3N4Ar7e6DorlhJCt/5BCDpYH6EZE7uyEP/N++Y44fwuGDW SELw== X-Forwarded-Encrypted: i=1; AFNElJ8oE2YSohPsbn3mF7LvNLVnf3a1b44JvdjPNiJc3jftCjhHxCwGQoTun/22/gVCUT/mxTj4OYONQ5PU6Fm+VUsp7i2lrg==@freebsd.org X-Gm-Message-State: AOJu0YzXmCZsKBVF34rOw/sr1i/lgTJm6x97hv00xBIJP1euRyZjPzeo A8d/DlUaxV0I6f63z13fXHnSKmAXBMCY4EXzBtB5BMbqTLDKtyu0TZ+1JxVu8w== X-Gm-Gg: AeBDievx9y/4XqJbA98HhRQxVaVA3GaTsnvoeTkCgxiIeufCcM/sbMq5SHN+PJ45Qsh jJSDUuJXeRq2wk/7QDc5wCMfQLzQZdGxjx6PNcmUFmUFLcoP1OeY90DWrc5rxxNd/S+ncwLEb8B RcSMRtkWgvfY49hlkE9eYsH6sZ7Uds7JyBKY4bk+PX63g1hT0Vw28qXB8p8Rirf28inL3eM/aLX fPsugdXsIbeQGEqM/V02u4aWb/bGoo8TZ/kua3QkZqVAn1IKDFm0etaDLi1TDRB+Y2mFfiafyWK Kep+rumhjcZtSmqRiwxv49VZpXDO2Fib5K+iukeU5b+vrB04+frtnVX0rQ2hwNF8GUap8aoktE4 uwHC4ofZaidCuxq4yB81SYdztsNx/h6D1Ttlg/NfSdB/h6f5rZnOcbUA4kNg2+gz64hpo51I4ES gGhMr4+EVT5oWLJSzL0f2Y9Xt9VumytLJfZb4lSYDKLXh/UyTPsgq/Fv7Z4BTxWwnvThh2jZI= X-Received: by 2002:a05:6a21:3384:b0:398:6ea8:21f7 with SMTP id adf61e73a8af0-3a39c0828e5mr5250016637.15.1777400498047; Tue, 28 Apr 2026 11:21:38 -0700 (PDT) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com. [209.85.215.175]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fc2ba84a2sm3084499a12.13.2026.04.28.11.21.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 11:21:37 -0700 (PDT) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c7961d7bc09so4760778a12.1 for ; Tue, 28 Apr 2026 11:21:37 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ9WStfaVpJbSoVrNP9+5d8aoOH4pxSQ1DW4lMVcU2NYQgDYBRbD9miyj65EzSUei30qsMjn3S39ueNaOcVW4L2ZWCrTYQ==@freebsd.org X-Received: by 2002:a17:90b:4b90:b0:35e:58d3:3286 with SMTP id 98e67ed59e1d1-364920417b7mr4399801a91.24.1777400497661; Tue, 28 Apr 2026 11:21:37 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69f0ea0c.19f57.339fcc06@gitrepo.freebsd.org> <20260428180947.83C47130@slippy.cwsent.com> In-Reply-To: <20260428180947.83C47130@slippy.cwsent.com> From: Chuck Tuffli Date: Tue, 28 Apr 2026 11:21:26 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4L4ijm9cEQkgzNjVJfnVQnJN5dMbunA8HuksnHlisfSP3HWS4_K6iNNHeo Message-ID: Subject: Re: git: 68e5b71517e9 - main - Vendor import of smart at 1.0.2 To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g4pfq4zWBz3rCr X-Spamd-Bar: ---- On Tue, Apr 28, 2026 at 11:09=E2=80=AFAM Cy Schubert wrote: > > In message <69f0ea0c.19f57.339fcc06@gitrepo.freebsd.org>, Chuck Tuffli > writes: > > The branch main has been updated by chuck: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D68e5b71517e947b4e3f349c9= 70af362b > > 47b45f27 > > > > commit 68e5b71517e947b4e3f349c970af362b47b45f27 > > Author: Chuck Tuffli > > AuthorDate: 2026-04-28 16:55:50 +0000 > > Commit: Chuck Tuffli > > CommitDate: 2026-04-28 17:08:27 +0000 > > > > Vendor import of smart at 1.0.2 > > > > smart/diskhealth is a command line application to monitor disk heal= th > > from a storage device via SMART. > > > > Reviewed by: fuz, jrm > > Relnotes: yes > > Differential Revision: https://reviews.freebsd.org/D56638 > > --- > > contrib/smart/Changelog | 37 ++ > > contrib/smart/LICENSE | 13 + > > contrib/smart/Makefile | 26 + > > contrib/smart/freebsd_dev.c | 828 +++++++++++++++++++++++++ > > contrib/smart/libsmart.c | 1359 +++++++++++++++++++++++++++++++++= ++++++ > > ++ > > contrib/smart/libsmart.h | 174 ++++++ > > contrib/smart/libsmart_desc.c | 158 +++++ > > contrib/smart/libsmart_dev.h | 60 ++ > > contrib/smart/libsmart_priv.h | 83 +++ > > contrib/smart/smart.8 | 245 ++++++++ > > contrib/smart/smart.c | 334 ++++++++++ > > packages/Makefile | 1 + > > packages/smart/Makefile | 4 + > > packages/smart/smart.ucl | 30 + > > usr.sbin/Makefile | 1 + > > usr.sbin/smart/Makefile | 8 + > > 16 files changed, 3361 insertions(+) > > Why are we doing vendor imports directly to contrib/? Is this a new > procedure, do we not need to use the vendor branch anymore? Sorry, this is new territory for me, and I may have goofed. My understanding was the upstream code lives in a vendor/* branch (which I forgot to push) and the contents are copied to the contrib/* directory and then committed. If this isn't the right thing to do, let me know how to fix this. --chuck