Date: Thu, 26 Jun 2003 10:12:07 -0700 (PDT) From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c Message-ID: <20030626100854.P74937@root.org> In-Reply-To: <XFMail.20030626114023.jhb@FreeBSD.org> References: <XFMail.20030626114023.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 26 Jun 2003, John Baldwin wrote: > Should be "hint.ips.0.disabled". Perhaps we need to add a resource_disabled() > function to abstract this so people stop getting it wrong. Something like: With you so far... > You could then expand this function to check 'disable' as well if > desired and allow for 'true' and 'false', 'on' and 'off' in addition > to '0' and '1'. ...And then you lost me. :) I think that binary flags should only have one way to set/clear them. Adding options only increases confusion (i.e. what about TRUE or yes/no)? The int approach seems ok. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030626100854.P74937>