From owner-svn-src-stable@FreeBSD.ORG  Sat May  5 17:10:18 2012
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BEC57106566B;
	Sat,  5 May 2012 17:10:18 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id E69DD8FC08;
	Sat,  5 May 2012 17:10:11 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q45HA5mQ066520;
	Sat, 5 May 2012 21:10:05 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q45HA5VG066519;
	Sat, 5 May 2012 21:10:05 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Sat, 5 May 2012 21:10:05 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
	svn-src-stable@FreeBSD.org, svn-src-stable-8@FreeBSD.org
Message-ID: <20120505171005.GP18777@FreeBSD.org>
References: <201205051005.q45A5DTD050083@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201205051005.q45A5DTD050083@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: 
Subject: Re: svn commit: r235053 - stable/8/sys/netinet
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
	<svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>, 
	<mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
	<mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 17:10:18 -0000

On Sat, May 05, 2012 at 10:05:13AM +0000, Gleb Smirnoff wrote:
T> Author: glebius
T> Date: Sat May  5 10:05:13 2012
T> New Revision: 235053
T> URL: http://svn.freebsd.org/changeset/base/235053
T> 
T> Log:
T>   Merge 234342 from head:
T>     When we receive an ICMP unreach need fragmentation datagram, we take
T>     proposed MTU value from it and update the TCP host cache. Then
T>     tcp_mss_update() is called on the corresponding tcpcb. It finds the
T>     just allocated entry in the TCP host cache and updates MSS on the
T>     tcpcb. And then we do a fast retransmit of what we have in the tcp
T>     send buffer.
T>   
T>     This sequence gets broken if the TCP host cache is exausted. In this
T>     case allocation fails, and later called tcp_mss_update() finds nothing
T>     in cache. The fast retransmit is done with not reduced MSS and is
T>     immidiately replied by remote host with new ICMP datagrams and the
T>     cycle repeats. This ping-pong can go up to wirespeed.
T>   
T>     To fix this:
T>     - tcp_mss_update() gets new parameter - mtuoffer, that is like
T>       offer, but needs to have min_protoh subtracted.
T>     - tcp_mtudisc() as notification method renamed to tcp_mtudisc_notify().
T>     - tcp_mtudisc() now accepts not a useless error argument, but proposed
T>       MTU value, that is passed to tcp_mss_update() as mtuoffer.
T>   
T>     Reported by:  az
T>     Reported by:  Andrey Zonov <andrey zonov.org>
T>     Reviewed by:  andre (previous version of patch)
T>   
T>   Tested by:  Andrey Zonov <andrey zonov.org>

Sorry, should have been: tested by az.

Andrej Zverev did extensive testing on stable/8.

-- 
Totus tuus, Glebius.