From owner-svn-src-head@freebsd.org Tue Sep 3 14:32:36 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ED241C83D2; Tue, 3 Sep 2019 14:32:36 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N8Yb74Tdz3R6X; Tue, 3 Sep 2019 14:32:35 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id u185so32556673iod.10; Tue, 03 Sep 2019 07:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HfbcKqEqCv0W/wImRriEfyTk/Ju3nh4IK0iw9d6bWHA=; b=f/K+cq5XEvWd6p5WP8iB0XVenC1lRt2WWbhO79z2VhPw72qnHiGEE0svoPiAEgo/ae gL99jQncnaLjN83ZzA24IpTaq7kOFjL+wo934B1m/OBrRWVJOWy/Q7/V8vRWPOZPGZtJ X+bN/vTH9zN4Apccw8JZBtGVdXt75ezfbbaL4To6fsX0dMCFx9SMWKyJtB2Ww8T+xkWy UQyRyyBjSJsY2gQrpivcxFAgfAnIe0tVybMRrutB9AKwblhdJ5R4psgfBX/Tc34CbFlq oexCX5FgxxPItP7cBC5GWZBo3pBRhRkaORKcaRIJaywhIRQnHp7ZHo63Drm7o/3lEEoz 0L9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HfbcKqEqCv0W/wImRriEfyTk/Ju3nh4IK0iw9d6bWHA=; b=mc3OED6y9I3fkXY6HcpIpUkLb4xtz6AVlBVcx3RW/Re+ZVFG9W9j/R3FPr8yDxKHHn TFxBv9SNIfEJPwyixjp08i2p8hODvbOq5zU8JlK0bR/4dT2K1l0Qp9vkpbr9YizlDARw 7pX7y301JcINaIY7lB7EulRJT0jwjphHGBT2GeKqoOw37BT7TLpSRbBJDy0JbtP2tI0a wPPH7Kxey4xmuCKD9P60b+5qEZandaA9bCc+MBqFTiXT8cv/LIUghB7Apxuif0KwlT9y MC81FxSurKYsQhzPDeYinfhTeDICj4oc4Z38xXM9MV+1DMM/bjmeNHgO41r7bvtB7s3X A+FA== X-Gm-Message-State: APjAAAUUUdZ6/2VdE+Tx2HODiQV27C/EbOhjLzPYGT2m0esrQOUlD6ib saETNyYLGVr+7AA9GhoXY6ZcelEr2uc= X-Google-Smtp-Source: APXvYqxJ6WgXiAtGZzlTA7xNP3dY1zQWcKfyiblfF8KqHsVtlqZ/OjQYGrKvQp5WzllznUCnjApD4A== X-Received: by 2002:a5d:8457:: with SMTP id w23mr1834194ior.189.1567521154734; Tue, 03 Sep 2019 07:32:34 -0700 (PDT) Received: from ralga.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id a6sm16861485ios.20.2019.09.03.07.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 07:32:34 -0700 (PDT) Date: Tue, 3 Sep 2019 09:32:27 -0500 From: Justin Hibbits To: Shawn Webb Cc: Brooks Davis , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903093227.08bfdd8f@ralga.knownspace> In-Reply-To: <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> <20190903114740.gbzkeffdce3mkee2@mutt-hbsd> <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46N8Yb74Tdz3R6X X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=f/K+cq5X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2607:f8b0:4864:20::d43 as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-3.95 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; RECEIVED_SPAMHAUS_PBL(0.00)[129.245.25.173.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (2.12), ipnet: 2607:f8b0::/32(-2.81), asn: 15169(-2.30), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 14:32:37 -0000 On Tue, 3 Sep 2019 10:20:35 -0400 Shawn Webb wrote: > On Tue, Sep 03, 2019 at 07:47:40AM -0400, Shawn Webb wrote: > > On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote: > > > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > > > > Hey Mateusz, > > > > > > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > > > > Author: mjg > > > > > Date: Tue Sep 3 04:16:30 2019 > > > > > New Revision: 351729 > > > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > > > > > > > > Log: > > > > > Add sysctlbyname system call > > > > > > > > > > Previously userspace would issue one syscall to resolve the > > > > > sysctl and then another one to actually use it. Do it all in > > > > > one trip. > > > > > Fallback is provided in case newer libc happens to be > > > > > running on an older kernel. > > > > > > > > > > Submitted by: Pawel Biernacki > > > > > Reported by: kib, brooks > > > > > Differential Revision: > > > > > https://reviews.freebsd.org/D17282 > > > > > > > > > > Modified: > > > > ... snip ... > > > > > head/sys/sys/param.h > > > > > > > > ... snip ... > > > > > > > > > > > > > > Modified: head/sys/sys/param.h > > > > > ============================================================================== > > > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 > > > > > 2019 (r351728) +++ head/sys/sys/param.h Tue Sep > > > > > 3 04:16:30 2019 (r351729) @@ -60,7 +60,7 @@ > > > > > * in the range 5 to 9. > > > > > */ > > > > > #undef __FreeBSD_version > > > > > -#define __FreeBSD_version 1300044 /* Master, > > > > > propagated to newvers */ +#define __FreeBSD_version > > > > > 1300045 /* Master, propagated to newvers */ > > > > > > > > To an outsider, it seems that __FreeBSD_version tends to be > > > > bumped in a separate commit. Am I remembering that right? > > > > > > It should be bumped in the same commit, but people forget or the > > > bump they have in their review turns into a no-op because someone > > > else does a bump in the interim (the latter has bit me several > > > times). > > > > Interesting. Thanks for the clarification! > > One thought for making the version bump a seperate commit is if the > original commit needed to be reverted, the commit can be reverted > wholesale (well, from the perspective of __FreeBSD_version) without > worry of accidentally decrementing the version number to a prior > value. > > That's my "need-more-caffeine" verbose way of saying "separating the > version bump from the actual work allows for easier maintenance of the > version number, helping ensure an always-increasing number." > > Sorry if I sound dry here. My ten-month-old puppy is tiring me out way > faster than I can tire him out. > > Thanks, > I always thought convention was separate commits to ease MFCs. The few times I've bumped __FreeBSD_version I've done it explicitly as a followup commit for that reason. Guess I now know better :) - Justin