From owner-freebsd-testing@FreeBSD.ORG Fri Apr 11 19:06:44 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DFF7FE22 for ; Fri, 11 Apr 2014 19:06:43 +0000 (UTC) Received: from mail-yk0-f172.google.com (mail-yk0-f172.google.com [209.85.160.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D22811EA for ; Fri, 11 Apr 2014 19:06:43 +0000 (UTC) Received: by mail-yk0-f172.google.com with SMTP id 200so5266399ykr.17 for ; Fri, 11 Apr 2014 12:06:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=4zFRZy0kZpMYze9CnJO0eJTJ8Q2tR33Nac08s2jYZsM=; b=gLRRuWGdnq9/WST5/wyKAOZjdL6JZ5bZUjVqrtYFso+TuH8U4q1kRlyefgq+l7Q8E6 fN3wF39sT2kuXpdp3NKrHqKSZdNWVMog0VWGK+CKgwz+9KCCKNVA47FIwBzxHl8bh2wF LhGUHCXx3gDb8zfCs9WTrBEt93NHlg1DtOwkJyUs3FwDA4zH4139klnhcpbn673AJ620 TXEYvNgDt5QYBgMesrqrJlDwivXLY9r4Jgm5YVEL29kwI7rlukW1SBgWkcp0g2dOEXvf 1kFP2YCnjePxfaUyf8mlAvqglwxl6DJuPP4z28oRc8AIYptwq2bLoil2PpuTG9KO6apb ZuKA== X-Gm-Message-State: ALoCoQkJYE/HduhchMiAgveCGDa0xW12KCJ+dyS//l087eYJ6VTRX2egW4faLsOJN28YzOm1Z0SP X-Received: by 10.236.220.72 with SMTP id n68mr15177103yhp.102.1397242895484; Fri, 11 Apr 2014 12:01:35 -0700 (PDT) Received: from dhcp-172-26-107-241.nyc.corp.google.com (dhcp-172-26-107-241.nyc.corp.google.com [172.26.107.241]) by mx.google.com with ESMTPSA id s26sm10731834yhg.4.2014.04.11.12.01.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Apr 2014 12:01:34 -0700 (PDT) Sender: Julio Merino Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: Please provide process for small, targeted fixes in tools/regression From: Julio Merino In-Reply-To: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> Date: Fri, 11 Apr 2014 15:01:33 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <5F1D5D49-5F39-4EAC-89D5-E4D10FB3B01E@freebsd.org> References: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> To: "Peel, Casey" X-Mailer: Apple Mail (2.1874) Cc: "freebsd-testing@freebsd.org" , "bdrewery@FreeBSD.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 19:06:44 -0000 Hello Casey, On Apr 11, 2014, at 13:56, Peel, Casey wrote: > I have several small, targted fixes to files in src/tools/regression/ = to: >=20 > 1) enable existing *.t tests to run that were failing This is not "too hard" but is certainly tricky. I did a bunch of them about a month ago but didn't write a lot of = documentation on the topic. You can find some useful notes in = http://goo.gl/rWpdDR though, which includes slides and accompanying = notes for the tutorial I gave at AsiaBSDCon. Most of that ought to be = converted to actual documentation of course. The very first step, which is arguably the hardest, is to get the tests = to work while running them with the prove(1) tool. This has several = implications (an important one being that any testing logic must be = removed from the Makefile). > 2) add new *.t files for directories that enable running = TAP-enabled binaries through prove That's good as a second step. I suspect these new *.t files will just = invoke another script (the actual test), which means the .t files will = be removed when the tests are hooked into the test suite. But that's = fine: it's better to get them running with prove(1) first because then = the move is simple enough. > 3) *.c updates to remove clang compiler warnings Yes please. Once the tests run with prove(1) and pass, we can bundle them into the = test suite. This roughly involves moving the code to corresponding = 'tests/' subdirectories, writing Makefiles and updating the mtree. = Mostly mechanical (but very annoying when the tests provide tons of data = files; see usr.bin/make/tests/). > Can someone please provide a process for getting these approved and = committed in a timely manner? I would prefer to get these upstream and = then pull them down if at all possible, but I simply don't have time for = these to languish for weeks in a committee. >=20 > Isilon has BSD committers (eg: bdrewery) I can leverage if that would = be more expedient but given these are all testing-centric it seems like = getting approval from one or more people on freebsd-testing would be = best. If you can get self-contained diffs, I can try to get them in for you = (but can't make any promises as my time for FreeBSD varies significantly = week to week...) For simplicity of review, I'd appreciate at least one patch for every = subdirectory within tools/regression/foo/bar/ with at least one patch to = get the first tests up and running first with prove(1). More patches = are better! The move of the fixed tests to the new infrastructure (aka the = boilerplate work) is something I may be able to help with.=