Date: Sat, 5 Dec 2020 06:42:47 +0000 (UTC) From: Baptiste Daroussin <bapt@FreeBSD.org> To: Thomas Munro <thomas.munro@gmail.com> Cc: Yuri Pankov <yuripv@yuripv.dev>, hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data Message-ID: <5b8f1016-bcb3-42ff-9e70-c4c0240ea685@FreeBSD.org> In-Reply-To: <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com> References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
5 d=C3=A9c. 2020 02:25:29 Thomas Munro <thomas.munro@gmail.com>:
> On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt@freebsd.org> wrot=
e:
>> I do like what I see here, the only reason I haven't review is that I ca=
n't
>> test, since the last modification from hrs@ in the locale generation too=
ls each
>> time I try to regenerate the locales it fails.
>
> During install?=C2=A0 I noticed that too but wasn't sure of the correct f=
ix, perhaps:
>
> diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
> index 76fff6acb17..b6ae2feadac 100644
> --- a/tools/tools/locale/Makefile
> +++ b/tools/tools/locale/Makefile
> @@ -95,7 +95,7 @@ install: install-${t}
> install-${t}:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cd ${LOCALESRCDIR}/${t} && \
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rm -f =
Makefile *.src && \
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -c =
${t}/* ${LOCALESRCDIR}/${t}
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -c =
${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
> .=C2=A0 endif
> .endfor
Nope that one was easy to figure out, but once the locales are regenerated,=
localdef dies on plenty of them (non unicode mostly).
It does with the current setup as well as with an update of both cldr and u=
n unicode
Best regards,
Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b8f1016-bcb3-42ff-9e70-c4c0240ea685>