From owner-freebsd-hackers@freebsd.org Sat Dec 5 06:42:50 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A523147083A for ; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Cp0Pk4DRjz4pvP for ; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 912154705E8; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 90E93470986 for ; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cp0Pk3fp9z4q3N; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (unknown [IPv6:2001:41d0:8:db4c::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 57B6023214; Sat, 5 Dec 2020 06:42:50 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from [127.0.0.1] (10.246.39.62.rev.sfr.net [62.39.246.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ivaldir.etoilebsd.net (Postfix) with ESMTPSA id 1A9B449D97; Sat, 5 Dec 2020 07:42:48 +0100 (CET) Date: Sat, 5 Dec 2020 06:42:47 +0000 (UTC) From: Baptiste Daroussin To: Thomas Munro Cc: Yuri Pankov , hackers@freebsd.org Message-ID: <5b8f1016-bcb3-42ff-9e70-c4c0240ea685@FreeBSD.org> In-Reply-To: References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> Subject: Re: locale-related review, wcwidth() data MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <5b8f1016-bcb3-42ff-9e70-c4c0240ea685@FreeBSD.org> X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2020 06:42:50 -0000 5 d=C3=A9c. 2020 02:25:29 Thomas Munro : > On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin wrot= e: >> I do like what I see here, the only reason I haven't review is that I ca= n't >> test, since the last modification from hrs@ in the locale generation too= ls each >> time I try to regenerate the locales it fails. > > During install?=C2=A0 I noticed that too but wasn't sure of the correct f= ix, perhaps: > > diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile > index 76fff6acb17..b6ae2feadac 100644 > --- a/tools/tools/locale/Makefile > +++ b/tools/tools/locale/Makefile > @@ -95,7 +95,7 @@ install: install-${t} > install-${t}: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cd ${LOCALESRCDIR}/${t} && \ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rm -f = Makefile *.src && \ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -c = ${t}/* ${LOCALESRCDIR}/${t} > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -c = ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t} > .=C2=A0 endif > .endfor Nope that one was easy to figure out, but once the locales are regenerated,= localdef dies on plenty of them (non unicode mostly). It does with the current setup as well as with an update of both cldr and u= n unicode Best regards, Bapt