From owner-svn-src-head@FreeBSD.ORG  Wed Dec 17 14:29:52 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B1EDB106564A;
	Wed, 17 Dec 2008 14:29:52 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au
	[211.29.132.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 487778FC1D;
	Wed, 17 Dec 2008 14:29:52 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c220-239-231-178.carlnfd4.nsw.optusnet.com.au
	(c220-239-231-178.carlnfd4.nsw.optusnet.com.au [220.239.231.178])
	by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	mBHEThTB020471
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 18 Dec 2008 01:29:44 +1100
Date: Thu, 18 Dec 2008 01:29:43 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: <alpine.BSF.1.10.0812171244310.75599@fledge.watson.org>
Message-ID: <20081218010226.K6569@delplex.bde.org>
References: <200812161703.mBGH3M7m042955@svn.freebsd.org>
	<200812161821.37686.max@love2party.net>
	<alpine.BSF.1.10.0812161751250.75599@fledge.watson.org>
	<86myevgley.fsf@ds4.des.no>
	<alpine.BSF.1.10.0812171244310.75599@fledge.watson.org>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-1793079619-1229524183=:6569"
Cc: src-committers@FreeBSD.org, jhb@FreeBSD.org, svn-src-all@FreeBSD.org,
	Max Laier <max@love2party.net>, svn-src-head@FreeBSD.org,
	=?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
Subject: Re: svn commit: r186187 - head/sys/net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2008 14:29:52 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1793079619-1229524183=:6569
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 17 Dec 2008, Robert Watson wrote:

> On Wed, 17 Dec 2008, Dag-Erling Sm=C3=B8rgrav wrote:
>
>> Robert Watson <rwatson@FreeBSD.org> writes:
>>>              exit(EX_OK);    /*
>>>                               * Avoid obvious comments such as
>>>                               * "Exit 0 on success."
>>>                               */
>>=20
>> Umm, didn't we agree *not* to use sysexits?
>
> Dunno, that one is not mine:
>
> Annotations for style.9
> ***************
> 1.5          (joerg    31-Mar-96): =09exit(EX_OK);=09/*
> 1.38         (alex     28-Oct-00): =09exit(EX_USAGE);

1.5 is the original commit that added sysexits to style.9.

It also broke the comment -- it is no longer obvious that exit(EX_OK)
exits with status 0 on success.

Also, reformatting the comment gave the bad example of a block comment
to the right of the code.  The original code instead gave an example
of abnormally indenting the comment so as to fit it in 80 columns:

%%%
 =09exit(0);    /* Avoid obvious comments such as "Exit 0 on success." */
%%%

The comment is indented to column 20 instead of the usual 40 or 32.

The reformatting is part of another bug suite -- to coerce
/usr/src/admin/style/style into a man page, 5 leading spaces had to
be added for man page indentation.  This required reformatting to keep
fitting in 80 columns and messes up tabs.

Bruce
--0-1793079619-1229524183=:6569--