Date: Tue, 15 Dec 2015 04:43:28 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r292245 - head/sys/mips/atheros Message-ID: <201512150443.tBF4hSrA088611@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Tue Dec 15 04:43:28 2015 New Revision: 292245 URL: https://svnweb.freebsd.org/changeset/base/292245 Log: [arge] add a comment about needing mdio busses in order to use the interface. This is a holdover from how reset is handled in the ARGE_MDIO world. You need to define the mdio bus device if you want to use the ethernet device or the arge setup path doesn't bring the MAC out of reset. Modified: head/sys/mips/atheros/if_arge.c Modified: head/sys/mips/atheros/if_arge.c ============================================================================== --- head/sys/mips/atheros/if_arge.c Tue Dec 15 04:28:31 2015 (r292244) +++ head/sys/mips/atheros/if_arge.c Tue Dec 15 04:43:28 2015 (r292245) @@ -885,6 +885,11 @@ arge_attach(device_t dev) /* * Don't do this for the MDIO bus case - it's already done * as part of the MDIO bus attachment. + * + * XXX TODO: if we don't do this, we don't ever release the MAC + * from reset and we can't use the port. Now, if we define ARGE_MDIO + * but we /don't/ define two MDIO busses, then we can't actually + * use both MACs. */ #if !defined(ARGE_MDIO) /* Initialize the MAC block */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512150443.tBF4hSrA088611>