From owner-svn-src-all@freebsd.org Tue Dec 15 04:43:29 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E7FBA43DF4; Tue, 15 Dec 2015 04:43:29 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3F57D1F8E; Tue, 15 Dec 2015 04:43:29 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id tBF4hS1T088612; Tue, 15 Dec 2015 04:43:28 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id tBF4hSrA088611; Tue, 15 Dec 2015 04:43:28 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <201512150443.tBF4hSrA088611@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Tue, 15 Dec 2015 04:43:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r292245 - head/sys/mips/atheros X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 04:43:29 -0000 Author: adrian Date: Tue Dec 15 04:43:28 2015 New Revision: 292245 URL: https://svnweb.freebsd.org/changeset/base/292245 Log: [arge] add a comment about needing mdio busses in order to use the interface. This is a holdover from how reset is handled in the ARGE_MDIO world. You need to define the mdio bus device if you want to use the ethernet device or the arge setup path doesn't bring the MAC out of reset. Modified: head/sys/mips/atheros/if_arge.c Modified: head/sys/mips/atheros/if_arge.c ============================================================================== --- head/sys/mips/atheros/if_arge.c Tue Dec 15 04:28:31 2015 (r292244) +++ head/sys/mips/atheros/if_arge.c Tue Dec 15 04:43:28 2015 (r292245) @@ -885,6 +885,11 @@ arge_attach(device_t dev) /* * Don't do this for the MDIO bus case - it's already done * as part of the MDIO bus attachment. + * + * XXX TODO: if we don't do this, we don't ever release the MAC + * from reset and we can't use the port. Now, if we define ARGE_MDIO + * but we /don't/ define two MDIO busses, then we can't actually + * use both MACs. */ #if !defined(ARGE_MDIO) /* Initialize the MAC block */