From owner-freebsd-current Wed Mar 19 9:28:10 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51A5937B401; Wed, 19 Mar 2003 09:28:09 -0800 (PST) Received: from out002.verizon.net (out002pub.verizon.net [206.46.170.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B10E43F3F; Wed, 19 Mar 2003 09:28:08 -0800 (PST) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net ([151.200.237.70]) by out002.verizon.net (InterMail vM.5.01.05.27 201-253-122-126-127-20021220) with ESMTP id <20030319172807.KLJI6546.out002.verizon.net@kokeb.ambesa.net>; Wed, 19 Mar 2003 11:28:07 -0600 Date: Wed, 19 Mar 2003 12:28:06 -0500 From: Mike Makonnen To: "Scott Sipe" Cc: des@freebsd.org, joris@vandalon.nl, freebsd-current@FreeBSD.ORG Subject: Re: pkg_add segfault In-Reply-To: <006801c2ee2e$a43099b0$60ee1098@stark> References: <20030319151959.GA643@mezzanine.vandalon.nl> <006801c2ee2e$a43099b0$60ee1098@stark> X-Mailer: Sylpheed version 0.8.10 (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH at out002.verizon.net from [151.200.237.70] at Wed, 19 Mar 2003 11:28:06 -0600 Message-Id: <20030319172807.KLJI6546.out002.verizon.net@kokeb.ambesa.net> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Here's a patch. Des, is this ok with you? Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | Fingerprint: D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 Index: lib/libfetch/ftp.c =================================================================== RCS file: /home/ncvs/src/lib/libfetch/ftp.c,v retrieving revision 1.86 diff -u -r1.86 ftp.c --- lib/libfetch/ftp.c 11 Mar 2003 08:20:58 -0000 1.86 +++ lib/libfetch/ftp.c 19 Mar 2003 17:24:20 -0000 @@ -894,7 +894,7 @@ struct url *purl; char *p; - if (strchr(flags, 'd') != NULL) + if (flags != NULL && strchr(flags, 'd') != NULL) return (NULL); if (((p = getenv("FTP_PROXY")) || (p = getenv("ftp_proxy")) || (p = getenv("HTTP_PROXY")) || (p = getenv("http_proxy"))) && To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message