From owner-svn-src-head@FreeBSD.ORG Sat May 19 18:22:49 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 548B8106566B; Sat, 19 May 2012 18:22:49 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) by mx1.freebsd.org (Postfix) with ESMTP id C73948FC0C; Sat, 19 May 2012 18:22:48 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id BEA8625D3857; Sat, 19 May 2012 18:22:47 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DA92CBE74BC; Sat, 19 May 2012 18:22:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 46DySP-qdvR3; Sat, 19 May 2012 18:22:45 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 9EB97BE74BB; Sat, 19 May 2012 18:22:45 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <201205191755.q4JHtncx036628@svn.freebsd.org> Date: Sat, 19 May 2012 18:22:44 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <4CFA3665-472D-49E4-8832-3B304C2908D1@FreeBSD.org> References: <201205191755.q4JHtncx036628@svn.freebsd.org> To: Marcel Moolenaar X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235654 - in head: bin/ed share/mk X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2012 18:22:49 -0000 On 19. May 2012, at 17:55 , Marcel Moolenaar wrote: > Author: marcel > Date: Sat May 19 17:55:49 2012 > New Revision: 235654 > URL: http://svn.freebsd.org/changeset/base/235654 >=20 > Log: > Add build option MK_ED_CRYPTO to control whether ed(1) is to have the > ability to encrypt/decrypt files. Embedded systems can typically have > OpenSSL, but not for ed(1) to use it. This is totally wrong in my view and lacks documentation. 1) I really see no reason why ED needs it's own crypto flag for = src.conf, if we go that route what about telnet, and all the others? 2) If I do not build with OPENSSL this should as well turn off = MK_ED_CRYPTO automatically (but let's not go there, if avoidable). 3) if you insist on keeping it as a src.conf option please fix (2) and properly document it. >=20 > Obtained from: Juniper Networks, Inc. >=20 > Modified: > head/bin/ed/Makefile > head/share/mk/bsd.own.mk >=20 > Modified: head/bin/ed/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/bin/ed/Makefile Sat May 19 17:49:20 2012 = (r235653) > +++ head/bin/ed/Makefile Sat May 19 17:55:49 2012 = (r235654) > @@ -7,12 +7,12 @@ SRCS=3D buf.c cbc.c glbl.c io.c main.c re. > LINKS=3D ${BINDIR}/ed ${BINDIR}/red > MLINKS=3D ed.1 red.1 >=20 > -.if !defined(RELEASE_CRUNCH) > -.if ${MK_OPENSSL} !=3D "no" > +.if !defined(RELEASE_CRUNCH) && \ > + ${MK_OPENSSL} !=3D "no" && \ > + ${MK_ED_CRYPTO} !=3D "no" > CFLAGS+=3D-DDES > DPADD=3D ${LIBCRYPTO} > LDADD=3D -lcrypto > .endif > -.endif >=20 > .include >=20 > Modified: head/share/mk/bsd.own.mk > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/share/mk/bsd.own.mk Sat May 19 17:49:20 2012 = (r235653) > +++ head/share/mk/bsd.own.mk Sat May 19 17:55:49 2012 = (r235654) > @@ -334,6 +334,7 @@ __DEFAULT_YES_OPTIONS =3D \ > CXX \ > DICT \ > DYNAMICROOT \ > + ED_CRYPTO \ > EXAMPLES \ > FLOPPY \ > FORTH \ --=20 Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!