From owner-freebsd-toolchain@freebsd.org  Fri Sep 21 22:06:45 2018
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E62710A5CA4;
 Fri, 21 Sep 2018 22:06:45 +0000 (UTC)
 (envelope-from markjdb@gmail.com)
Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com
 [IPv6:2607:f8b0:4864:20::530])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A20D972CEF;
 Fri, 21 Sep 2018 22:06:44 +0000 (UTC)
 (envelope-from markjdb@gmail.com)
Received: by mail-pg1-x530.google.com with SMTP id d1-v6so6635380pgo.3;
 Fri, 21 Sep 2018 15:06:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=2516+QDjEhD1sfCZ75g2L281nMOhCPm+smD2EO186ag=;
 b=EFzkTYpaGhe66fmNJFeFt9sqbU82/ccGqLCw7E1BMdTVx5Ott2Fl1znGINeoUKgWE7
 UxoUa40F9Ird85mcSgHjywUOZoLAuAHOK8TiJjyHFlcdKhDCrUEpB1fwTpTAiollSgNj
 jSGtXZ54QCWwJ0L+EsW7rainLK+s/QrNug+kaJt1w0FxTC8cKWLpwclHhh4PRu8oYibA
 OpqD98JkXEGu6NoCqCsTA4B7dYs0uJa5zd4+wY0lhQqzARwVaHTyjLd28cBUGH2O/BmH
 fmxaNyiBCNLowllZZlv0uWUanLsZyKf65QDdiYjlVsexuXL2hQA92CDz4facn92GqfKZ
 dEYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:date:from:to:cc:subject:message-id
 :references:mime-version:content-disposition:in-reply-to:user-agent;
 bh=2516+QDjEhD1sfCZ75g2L281nMOhCPm+smD2EO186ag=;
 b=LEcP29hmXCyXaC7gr6gEpM7BxQ2xd5I25El0lXQdnyx2sRe0bgdexoipRUxWD2O/1L
 mbCueRV+9/IP7DnbAdsrJWdvkpe813YCFzs9lNYXjS8cWbP0H/SDfizYCjs1oosw14oh
 qklL77PL8iTT0eIzycRiDjQTJOPT5v2Vvc7W1vPvSJMejcRzOCyRuKs0+TMi1J0u4cyF
 CoYMP78u/pgMHJd1No7QYQurMUN1HfC7TH0UJeOZuIlO43tKCVG21bl7boJsaiowZPzC
 Pe9c/wFNrMAjpOr8WwLnKnH1uCEJPevNdLvl6rws8NqkJd3+Sx1syZxeSQNMgOyNWbGa
 B1NQ==
X-Gm-Message-State: APzg51A/gtsWxt1JrnxL3a95cOlm50K0UYaY5NrsddSYRl4BCQHOJljD
 34T581zSWumfLj1G2vOS4JUpqMIfSE4=
X-Google-Smtp-Source: ANB0VdY3DkQcWUU7Mwc5EW4J51PJlUHxsjJgiTO2G2X9qOGr9kq+PAue6bdBDfoKHlz25PJtszVLSQ==
X-Received: by 2002:a62:3184:: with SMTP id
 x126-v6mr47992836pfx.49.1537567603151; 
 Fri, 21 Sep 2018 15:06:43 -0700 (PDT)
Received: from raichu (toroon0560w-lp130-01-174-88-78-8.dsl.bell.ca.
 [174.88.78.8])
 by smtp.gmail.com with ESMTPSA id t123-v6sm35012025pfd.51.2018.09.21.15.06.41
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 21 Sep 2018 15:06:42 -0700 (PDT)
Sender: Mark Johnston <markjdb@gmail.com>
Date: Fri, 21 Sep 2018 18:06:39 -0400
From: Mark Johnston <markj@freebsd.org>
To: Ed Maste <emaste@freebsd.org>
Cc: Mark Millard <marklmi@yahoo.com>,
 FreeBSD Toolchain <freebsd-toolchain@freebsd.org>,
 FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: building head -r338675 with devel/amd64-gcc:
 /usr/local/x86_64-unknown-freebsd12.0/bin/ld: warning: -z ifunc-noplt
 ignored
Message-ID: <20180921220639.GF5120@raichu>
References: <2E7136DD-9C25-44C1-8C9A-310C2D1D7189@yahoo.com>
 <CAPyFy2BHUocGh-H8xfmdQXTTX_Qvoi50xKzoTGco8Cn9FfGcyQ@mail.gmail.com>
 <20180921193139.GB5120@raichu>
 <CAPyFy2DTw-LGXUVCP2W0MOW0bXWe2An18Y-Uy-U6X40UJCiy6w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPyFy2DTw-LGXUVCP2W0MOW0bXWe2An18Y-Uy-U6X40UJCiy6w@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Sep 2018 22:06:45 -0000

On Fri, Sep 21, 2018 at 04:37:08PM -0400, Ed Maste wrote:
> On 21 September 2018 at 15:31, Mark Johnston <markj@freebsd.org> wrote:
> >
> > Perhaps the following?  It's not quite right since it'll still use
> > -zifunc-noplt with an external LLVM toolchain, but I can't seem to
> > figure out how to define a linker feature for only non-cross toolchains.
> > In any case, we're going to upstream the option soon.
> 
> I wouldn't worry too much about out-of-tree since it will be upstream
> soon as you say, otherwise looks good.
> 
> > +.if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386"
> > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == ""
> >  .error amd64/i386 kernel requires linker ifunc support
> >  .endif
> > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc-noplt} != ""
> 
> Maybe roll && defined(LINKER_FEATURES) into the outer .if?

https://reviews.freebsd.org/D17279 for anyone else that would like to
review.