From owner-freebsd-bugs@freebsd.org Fri Apr 30 20:04:13 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AEDB6628136 for ; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FX3H14P2Vz3LfP for ; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 96D28628135; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 969A6627F1E for ; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FX3H13mNyz3Lsb for ; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6A1A52523 for ; Fri, 30 Apr 2021 20:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 13UK4DEm074352 for ; Fri, 30 Apr 2021 20:04:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 13UK4DKn074351 for bugs@FreeBSD.org; Fri, 30 Apr 2021 20:04:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255061] [PATCH] Proof of concept nested mounts for automounter -hosts map Date: Fri, 30 Apr 2021 20:04:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: trasz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 20:04:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255061 Edward Tomasz Napierala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trasz@FreeBSD.org --- Comment #1 from Edward Tomasz Napierala --- Hello, and thank you! I'm really happy to see work being done on what's probably the main piece of functionality missing from our current automount= er. I like the approach you've taken. Regarding the unmounting problem (notes.= txt, #1): I agree about it being the primary missing piece. I'm not sure I like= the idea of recursive unmounts (or recursive anything) in the kernel. I wonder, though, using your example: /net (autofs) /net/foo/a (nfs, automounted) /net/foo/a/b (autofs, automounted) /net/foo/a/x (autofs, automounted) /net/foo/a/b/c (nfs, automounted) It should be technically possible (using 'umount -f') to forcibly unmount /net/foo/a despite /net/foo/a/b and its siblings still being mounted, and unmount the (now unaccessible) submounts afterwards. Thus, it might be possible to add a flag to the unmount(2) syscall to make it to fail the unmount(2) syscall with EBUSY if there are still vnodes open, except the on= es with autofs submounts mounted over it? Regarding notes.txt, #4: I think autofs(5) doesn't stop just the initial th= read that triggered the mount, but also all other attempts to access the same mountpoint - the threads should "queue up" on the automountd request struct= ure, and get unpaused after automountd signals the mount is done. As for all the other points, I generally agree, or just have nothing to add= at the moment. I've only skimmed through the source for now, but don't have a= ny major suggestions yet apart from a fairly general ones, eg that it might ma= ke sense to use tree(3) macros, or not check for NULL before free(3). I wonder, should we perhaps move this discussion to http://reviews.FreeBSD.= org? Thanks again! --=20 You are receiving this mail because: You are the assignee for the bug.=