From owner-freebsd-bugs@freebsd.org Sat Jun 20 19:07:35 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E640C330AD5 for ; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49q4tb5tfzz4bkl for ; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C7FAC330F1B; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C68E3330DCB for ; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49q4tb4gTBz4bbf for ; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 81D0510FE7 for ; Sat, 20 Jun 2020 19:07:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05KJ7Zbd071362 for ; Sat, 20 Jun 2020 19:07:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05KJ7Z2T071361 for bugs@FreeBSD.org; Sat, 20 Jun 2020 19:07:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 247445] ZFS - memory leak in dsl_scan_visitbp() Date: Sat, 20 Jun 2020 19:07:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jdolecek@NetBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2020 19:07:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247445 Bug ID: 247445 Summary: ZFS - memory leak in dsl_scan_visitbp() Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jdolecek@NetBSD.org Created attachment 215825 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D215825&action= =3Dedit Memory leak fix File: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c dsl_scan_visitbp() doesn't free allocated memory when dsl_scan_recurse() fa= ils. This is probably very rare, seems it's only possible on I/O errors. I've attached what I believe is the fix, but it's not tested. Memory leak was introduced with this change (git checkout): commit a73aecd5f1b3afb968ba2977945b1a62d47d0353 Author: sef Date: Fri Jun 8 17:38:28 2018 +0000 This originated from ZFS On Linux, as =20=20=20 https://github.com/zfsonlinux/zfs/commit/d4a72f23863382bdf6d0ae33196f5b5dec= bc48fd During scans (scrubs or resilvers), it sorts the blocks in each transac= tion group by block offset; the result can be a significant improvement. (On= my test system just now, which I put some effort to introduce fragmentation into the pool since I set it up yesterday, a scrub went from 1h2m to 33.5m w= ith the changes.) I've seen similar rations on production systems. Approved by: Alexander Motin Obtained from: ZFS On Linux Relnotes: Yes (improved scrub performance, with tunables) Differential Revision: https://reviews.freebsd.org/D15562 --=20 You are receiving this mail because: You are the assignee for the bug.=