From owner-freebsd-ports  Thu Jun 28  6:50:18 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 424CB37B403
	for <freebsd-ports@hub.freebsd.org>; Thu, 28 Jun 2001 06:50:04 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f5SDo4575857;
	Thu, 28 Jun 2001 06:50:04 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 28 Jun 2001 06:50:04 -0700 (PDT)
Message-Id: <200106281350.f5SDo4575857@freefall.freebsd.org>
To: freebsd-ports@FreeBSD.org
Cc: 
From: "Akinori MUSHA" <knu@iDaemons.org>
Subject: Re: ports/28481: ports japanese/eblook installation failure
Reply-To: "Akinori MUSHA" <knu@iDaemons.org>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

The following reply was made to PR ports/28481; it has been noted by GNATS.

From: "Akinori MUSHA" <knu@iDaemons.org>
To: sanewo@ba2.so-net.ne.jp
Cc: FreeBSD-gnats-submit@freebsd.org, shige@freebsd.org
Subject: Re: ports/28481: ports japanese/eblook installation failure
Date: Thu, 28 Jun 2001 22:49:23 +0900

 At Thu, 28 Jun 2001 21:50:40 +0900 (JST),
 sanewo@ba2.so-net.ne.jp wrote:
 > >Description:
 > 
 > When ${PREFIX}/${DOCDIR} already exists, ``make post-install'' fails because
 > test ([) command exits with non-zero status.
 > This situation is tipically the case when updating ports using portupgrade.
 
 Yeah, why don't we make every port portupgrade safe! :)
 
 ("portupgrade safe" here means to support overwriting installation)
 
 > Following patch should fix the problem:
 > 
 > --- Makefile.orig	Thu Jun 28 21:42:29 2001
 > +++ Makefile	Thu Jun 28 21:42:46 2001
 > @@ -24,7 +24,7 @@
 >  
 >  post-install:
 >  .if !defined(NOPORTDOCS)
 > -	@[ ! -d ${PREFIX}/${DOCDIR} ] && ${MKDIR} ${PREFIX}/${DOCDIR}
 > +	@[ ! -d ${PREFIX}/${DOCDIR} ] && ${MKDIR} ${PREFIX}/${DOCDIR} || true
 >  	@for i in AUTHORS COPYING ChangeLog NEWS README ; do \
 >  		${INSTALL_DATA} ${WRKSRC}/$${i} ${PREFIX}/${DOCDIR} ;\
 >  	done
 
 Well I think just:
 
 	@${MKDIR} ${PREFIX}/${DOCDIR}
 
 is sufficient because ${MKDIR} includes a -p option.
 
 -- 
                      /
                     /__  __            Akinori.org / MUSHA.org
                    / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
 Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp
 
 "Freeze this moment a little bit longer, make each impression
   a little bit stronger..  Experience slips away -- Time stand still"

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message