From owner-cvs-all Tue Apr 9 1:23:32 2002 Delivered-To: cvs-all@freebsd.org Received: from van-laarhoven.org (ap-z-5ab8.adsl.wanadoo.nl [212.129.218.184]) by hub.freebsd.org (Postfix) with SMTP id 183DA37B419 for ; Tue, 9 Apr 2002 01:23:26 -0700 (PDT) Received: (qmail 21708 invoked from network); 9 Apr 2002 08:23:24 -0000 Received: from heather.van-laarhoven.org (10.66.0.2) by uitsmijter.van-laarhoven.org with SMTP; 9 Apr 2002 08:23:24 -0000 Date: Tue, 9 Apr 2002 10:23:24 +0200 (CEST) From: Nick Hibma To: Hidetoshi Shimokawa Cc: Josef Karthauser , Hidetoshi Shimokawa , "cvs-committers@FreeBSD.org" , "cvs-all@FreeBSD.org" Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c scsi_da.c In-Reply-To: Message-ID: <20020409102222.M374-100000@heather.van-laarhoven.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > The umass driver returns the error just fine. See many postings on this > > in the appropriate mailing lists. > > some drives(not driver) do, but some don't. Don't do what? Return an error on receiving a command they don't understand? In that case your patch doesn't solve anything as the driver doesn't add or remove any error messages. > > At the moment the 6 byte commands are converted inside the umass driver > > to their 10 byte equivalents, so there should be no need for your patch > > in the first place (apart from the T_RBC bits of course, which looks > > like a good thing to me). > > I made this patch for SBP-II devices. Did you try it with the umass driver from current? Nick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message