From owner-svn-src-head@FreeBSD.ORG Tue Feb 17 20:32:59 2015 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E911DDE8; Tue, 17 Feb 2015 20:32:59 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A708CF47; Tue, 17 Feb 2015 20:32:59 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t1HKWvhc027727 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 Feb 2015 12:32:57 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t1HKWvCM027726; Tue, 17 Feb 2015 12:32:57 -0800 (PST) (envelope-from jmg) Date: Tue, 17 Feb 2015 12:32:57 -0800 From: John-Mark Gurney To: Gleb Smirnoff Subject: Re: svn commit: r278831 - head/sys/netpfil/pf Message-ID: <20150217203257.GH1953@funkthat.com> References: <201502160338.t1G3cRlX042385@svn.freebsd.org> <20150217173134.GZ1953@funkthat.com> <20150217202154.GS15484@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150217202154.GS15484@FreeBSD.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Tue, 17 Feb 2015 12:32:57 -0800 (PST) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 20:33:00 -0000 Gleb Smirnoff wrote this message on Tue, Feb 17, 2015 at 23:21 +0300: > On Tue, Feb 17, 2015 at 09:31:34AM -0800, John-Mark Gurney wrote: > J> Gleb Smirnoff wrote this message on Mon, Feb 16, 2015 at 03:38 +0000: > J> > Author: glebius > J> > Date: Mon Feb 16 03:38:27 2015 > J> > New Revision: 278831 > J> > URL: https://svnweb.freebsd.org/changeset/base/278831 > J> > > J> > Log: > J> > Update the pf fragment handling code to closer match recent OpenBSD. > J> > That partially fixes IPv6 fragment handling. Thanks to Kristof for > J> > working on that. > J> > > J> > Submitted by: Kristof Provost > J> > Tested by: peter > J> > Differential Revision: D1765 > J> > J> Looks like pf_flush_fragments still called in !INET case, though only > J> defined for INET case: > J> /scratch/tmp/jmg/src.head/sys/modules/pf/../../netpfil/pf/pf_norm.c:385:3: error: implicit declaration of function 'pf_flush_fragments' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > J> pf_flush_fragments(); > J> > J> when compiling LINT-NOINET kernel.. > J> > J> at least as of r278883... > J> > J> We need to get Jenkins to be compiling the LINT-NOINET kernel too.. > > Strange, since r278874 was tested with KERNCONF="LINT LINT-NOINET LINT-NOINET6". > > I will take a look. This is a result of a tinderbox build on ref10-amd64.freebsd.org... Look at /scratch/tmp/jmg/src.head/*NOINET -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."