From nobody Thu Oct 19 21:41:20 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBLkm4bbSz4xvPN for ; Thu, 19 Oct 2023 21:41:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBLkm2rRnz4Qbc for ; Thu, 19 Oct 2023 21:41:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697751680; a=rsa-sha256; cv=none; b=HkDXG6d1aCNfVHDhXbFwaSz+aQNAvw12MPLHBS6GuysuK8bQ+9PRg7VU8XKdYe/JI0z47m Rgnv3Isy1USNznr/ov2V6kDrKaVPbuk+aQ1pa4pDHSuMKQEUuU32sgmLQBpWXYTnE38qxG Z19hF2lIdhFJ1Cf7OAq9xBmB9xj8tB5z7J7rBVAuyvqFwkb9d6QGvKKTdyJns53c7uYCVo sl0feui0CSqQlhhvt0eYN28QPztowwTX0JrnGxm0SXEYwy1LZydFsU9hqEzNDyDzxc0fjp xRT2xHqzBdDj84ihW9qsUmZhfe7lxiTu0HckSdE0QRymM58mnzxgJyjbKjHPEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697751680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wcWQJ9sCTThsc1TCXv0lmlREjRRxgTuRTasWxdXaBdU=; b=rvMAL7BNNVZfSytUiyxTsLFMIIi9Wm22y6uxovNBQ361BeeiURVbCSX8jea9J+/h6Dlcqq 3M9m7oavkteyWuFJzJiQCjyVFsJ1IW9rrZLC/nIIzP26q5OmP8rcxSzZVi8815UEY7uCFl Z0Jt6s2pm47yo5qUutJfucK2Llo7owE8PFj13laMCmDc34wYfH7Ylyei34ON3Y6RofjyA2 DCyyeZ9pgAxWgsJPvUl27rzArJj8io0SyGh919kkABneZs/qqk9Pce69ULWkZ7NvvK76GK jRyGj835OLGK2db0dpXAvHKfn+0Elo6rfNXg9UOXLcOCsZugG6MsERa/fBBfxw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBLkm1v4Jz15fs for ; Thu, 19 Oct 2023 21:41:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39JLfKGv025240 for ; Thu, 19 Oct 2023 21:41:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39JLfKic025239 for bugs@FreeBSD.org; Thu, 19 Oct 2023 21:41:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273289] smartpqi: fix panic on removal of SAS drive Date: Thu, 19 Oct 2023 21:41:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273289 --- Comment #17 from commit-hook@FreeBSD.org --- A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D8fe059425a0919274e2c5b25a6af0568d= 147518d commit 8fe059425a0919274e2c5b25a6af0568d147518d Author: John F. Carr AuthorDate: 2023-10-19 03:25:31 +0000 Commit: Warner Losh CommitDate: 2023-10-19 21:37:29 +0000 smartpqi: Drop spinlock before freeing memory pqisrc_free_device frees the device softc with the os spinlock held. This causes crashes when devices are removed because the memory free might sleep (which is prohibited with spin locks held). Drop the spinlock before releasing the memory. MFC After: 2 days PR: 273289 Reviewed by: imp (cherry picked from commit b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547) (cherry picked from commit 1ad148a68ae74f3372b12b6e66fadf5ade384144) Approved-by: re (gjb) sys/dev/smartpqi/smartpqi_discovery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=