From owner-freebsd-scsi Tue Aug 13 2:50:11 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12E8637B400 for ; Tue, 13 Aug 2002 02:50:09 -0700 (PDT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3AF943E6E for ; Tue, 13 Aug 2002 02:50:07 -0700 (PDT) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id LAA06055 for freebsd-scsi@freebsd.org; Tue, 13 Aug 2002 11:50:06 +0200 (CEST) Received: from uriah.heep.sax.de (localhost.heep.sax.de [127.0.0.1]) by uriah.heep.sax.de (8.12.5/8.12.5) with ESMTP id g7D9frAS030902 for ; Tue, 13 Aug 2002 11:41:53 +0200 (MET DST) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.12.5/8.12.5/Submit) id g7D9frf9030901 for freebsd-scsi@freebsd.org; Tue, 13 Aug 2002 11:41:53 +0200 (MET DST) Date: Tue, 13 Aug 2002 11:41:53 +0200 From: Joerg Wunsch To: freebsd-scsi@freebsd.org Subject: Re: Tekram DC-395 driver maintenance Message-ID: <20020813114153.C3970@uriah.heep.sax.de> Reply-To: Joerg Wunsch Mail-Followup-To: Joerg Wunsch , freebsd-scsi@freebsd.org References: <20020811103649.G39683@uriah.heep.sax.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from nate@root.org on Mon, Aug 12, 2002 at 04:30:26PM -0700 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org As Nate Lawson wrote: > > In the course of investigating his problems, i eventually found out > > that there was one serious bug in that driver: upon detecting a CHECK > > CONDITION, they didn't set the appropriate CAM error flag > > (CAM_SCSI_STATUS_ERROR), so the CAM layer never bothered to handle the > > error at all. > I was able to get the fault once also but have not seemed to be able to > duplicate it. Were you able to track down where xpt failed to catch > the zero? In that case it wasn't xpt panicing, but somewhere in the slice code. Of course, since the CAM layer relied on the results of the geometry inquiry to be correct (since there was no error signalled), it passed them on to the upper layers which obviously assume that those figures make at least some sense (sector sizes of 0 don't make sense). > I don't have a problem with importing it but I defer to someone > who's been around longer. I'm guessing it should go in > sys/contrib/dev to ease style(9) and import impact. I thought that sys/contrib is a bit too much for just two files, but yes, i don't like the idea to stuff them into sys/pci, but would rather use sys/dev/trm instead. I think it's tolerable for imported vendor code to be not 100 % style(9) compliant, although i'd at least like to fix the 4-space hard tabs. However, this only makes sense if Tekram agrees on that change and is willing to also do that in their own sources. Otherwise it'll become a maintenance nightmare. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message