From owner-freebsd-ports@FreeBSD.ORG Thu Feb 6 21:23:39 2014 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C8217D05 for ; Thu, 6 Feb 2014 21:23:39 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 58E6D1706 for ; Thu, 6 Feb 2014 21:23:38 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MCxfb-1W1reV44Pb-009dM6 for ; Thu, 06 Feb 2014 22:23:37 +0100 Message-ID: <52F3FD59.4060708@gmx.de> Date: Thu, 06 Feb 2014 22:23:37 +0100 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "freebsd-ports@freebsd.org" Subject: Re: bsd.apache.mk Malformed conditional when APACHE_VERSION defined References: <52EE0BD3.8000006@heuristicsystems.com.au> <52EE2337.9080809@gmx.de> <52EF4613.9060006@heuristicsystems.com.au> In-Reply-To: <52EF4613.9060006@heuristicsystems.com.au> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:RK/dqOlJcsPZpav49ttwBMemmkW9irSK30E21YHhCUhBIjY0TdO m5FnKLvMQBIgibDZoDYyh9x6JVTdJh7adWtMdI2Ynq0n3XcYUZ7m0qk/qxT108iN/O2Gb2N cA8Pa1WvRXrelFcNuLZg7eYZX++2ieUaTccL7UZrMz/e2vJzVKH67ZxBz2AEAf0y3xJMjhF IBu+iHNaPmaLpU+yWRVog== Cc: Dewayne Geraghty X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2014 21:23:39 -0000 On 2014-02-03 08:32, Dewayne Geraghty wrote: > > On 2/02/2014 9:51 PM, olli hauer wrote: >> On 2014-02-02 10:11, Dewayne Geraghty wrote: >>> I filed a PR against textproc/htdig which should really be against the >>> ports systems. >>> >>> Would someone be kind enough to advise the current method to specify the >>> apache version. In ports.conf, I currently use >>> USE_APACHE=22 | APACHE_VERSION=22 >>> to specify the required version of apache for: >>> textproc/htdig >>> www/mod_security >>> lang/php5 >>> >>> I believe this PR >>> >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=186364 >>> >>> which probably should be routed to the ports system, and not textproc/htdig >>> >>> The error is: >>> cd /usr/ports/textproc/htdig && make -V UNIQUENAME >>> "/usr/ports/Mk/bsd.apache.mk", line 306: warning: String comparison >>> operator should be either == or != >>> "/usr/ports/Mk/bsd.apache.mk", line 306: Malformed conditional >>> (!empty(_APACHE_VERSION_MINIMUM) && (${_APACHE_VERSION} < >>> ${_APACHE_VERSION_MINIMUM})) >>> "/usr/ports/Mk/bsd.port.mk", line 6603: if-less endif >>> make: fatal errors encountered -- cannot continue >>> >>> which goes away if APACHE_VERSION isn't used, eg. >>> cd /usr/ports/textproc/htdig && make __MAKE_CONF=/dev/null -V UNIQUENAME >>> htdig >>> >> Hi Dewayne, >> >> APACHE_VERSION is a read only variable in case a port needs to know the >> installed / default Apache version -> do not set this variable! >> >> In case you want to specify a default apache use in etc/make.conf for example >> APACHE_PORT=www/apache22 >> >> See lines 12 - 25 in Mk/bsd.apache.mk >> >> > > Olli, > Thank-you for pointing me to the right place. I've removed > APACHE_VERSION=22; > but noted that > > PERL_VERSION=5.16.3 | PYTHON_VERSION=python2.7 > remain valid, which maintains my confusion. > > With the ongoing changes to the ports system, I've also retained this line in make.conf > DEFAULT_VERSIONS=perl5=5.16 python=2.7 python2=2.7 apache=22 Apache ports don't support the DEFAULT_VERSIONS variable because there are 5 different apache22 flavors that cannot run in a mix. See output from the command $ egrep 'apache2[24]' /usr/ports/www/Makefile | awk '{print "www/" $3}' www/apache22 (default prefork) www/apache22-event-mpm www/apache22-itk-mpm www/apache22-peruser-mpm www/apache22-worker-mpm www/apache24 So the only supported way for apache is to specify for example APACHE_PORT= www/apache22-worker-mpm > Though I suspect that using the latter is preferred and should be the stable way of constricting versions? > > The last rebuild of all ports occurred on Jan 20, strange that APACHE_VERSION=22 didn't halt that rebuild cycle, as bsd.apache.mk has been changed for 2 months... One of life's mysteries. The build of the www/htdig port has changed a little bit and does no longer include explicit so your issue popped up. Anyway if you run the www/apache22 port and not one of the 4 other flavors you don't need to specify anything. PS: can I close PR 186364 -- Regards, olli