From owner-cvs-all Wed Oct 17 11:52:41 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 89B5537B405; Wed, 17 Oct 2001 11:52:34 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id f9HIqUB36315; Wed, 17 Oct 2001 14:52:30 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 17 Oct 2001 14:52:30 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Jonathan Lemon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c In-Reply-To: <200110171830.f9HIUEW68725@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 17 Oct 2001, Jonathan Lemon wrote: > jlemon 2001/10/17 11:30:14 PDT > > Modified files: > sbin/ifconfig ifconfig.c > Log: > When specifying an interface to ifconfig, first look up the interface > index, then retrieve statistics for that index, rather than retrieving > all interfaces and then looking for a matching name. This allows the > user to refer to an interface via an alias name. > > While I'm here, also perform a few assorted cleanups. > > Revision Changes Path > 1.70 +12 -26 src/sbin/ifconfig/ifconfig.c Without looking at the commit itself, that sounds like it's subject to a race condition. How about adding the ability to retrieve interface statistics by name, rather than the indirection? Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message