From owner-svn-src-head@freebsd.org Sat Sep 22 18:24:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F8A9109F287 for ; Sat, 22 Sep 2018 18:24:29 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE38C7DBC4 for ; Sat, 22 Sep 2018 18:24:28 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm1-x341.google.com with SMTP id j25-v6so6673096wmc.1 for ; Sat, 22 Sep 2018 11:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3dUI76GVUoUsOop/X7mBovn/qvY7sVqAn+5srOX2mIw=; b=fHfngsUx68GJ3U7zg58cKkx4tbEYxxeYx+iaDTZjJck8Jy4j0t2R5xLlFMYnEVXzKZ xoVJZQFxCIRRq8vVaVtYckfjImof44eMnBnU+XL6eW7k6ev9cotMGNoNcRl3c9HA2+AX xEFFWSq1mZ6idXkn3plQjl0AY+9jkDz5BCLUkQs/DNjpJ3dc8JAM0dvnF6xotTHL2a4i 7kOSjjDAIEpGRr9vPHuZDzFOms16Yd5UCBLO57rfOL+BYTwNwOpleSYIQi6YllurIM5g STClA9qTllWAieCNxLwS2mqG5xNRQ2RzOHTVcUX5z+Vc+w+PreOa+wVkDgy4c4Zrxpm7 Vt7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3dUI76GVUoUsOop/X7mBovn/qvY7sVqAn+5srOX2mIw=; b=CuO74YawmxRTuPzrgYc08s8fw33e7C9HaU4toXbgctpCM9YGhmQNcFdQbpVxxiNtVi PKco4H6vUgjjOaFa+UlSROU+OU7kE3ouujB8gchjEOPiy8bMwU7PCG1c9kNTfSiwYDIb N3EEZbQOX5FQv9ysxhshH3JrSrFaYCtkE05nBeNLGRr1jd8SVlEeirVTJHKyEPXTWMvr sIWPqAmO1ALv8kpws2zf19plimaeSXuLFnT2irQFi0qtfMcKImlno13+xwne8xSDpFiC AG2dugxI0D7dv/wjt0ew9hrmOIekyOrdEwKV9zL0tHTxekvmHbrP4+4Ez7aL9KlgoBJl qpsA== X-Gm-Message-State: ABuFfohMR4KGYk4ZsrKalKGkdLRyg1cT8qG6Xv564tCUC5giww+U7wik wwTX5MzVu61qlypQ1SP28fWadw== X-Google-Smtp-Source: ANB0VdY8rwGKnbJ6pyxO9vlQlTxvKHMNV0+iXE+LXC6/VlXS+sdQ4ykeYLGqkofZMYCIaw6Q1PqGlg== X-Received: by 2002:a1c:df54:: with SMTP id w81-v6mr2098709wmg.6.1537640667454; Sat, 22 Sep 2018 11:24:27 -0700 (PDT) Received: from mutt-hbsd (slave237.starsellersworld.net. [85.199.141.237]) by smtp.gmail.com with ESMTPSA id j44-v6sm53141770wre.40.2018.09.22.11.24.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Sep 2018 11:24:26 -0700 (PDT) Date: Sat, 22 Sep 2018 14:24:14 -0400 From: Shawn Webb To: d@delphij.net Cc: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338861 - head/lib/libc Message-ID: <20180922182414.mrm5oavdjeu6bb3y@mutt-hbsd> References: <201809211749.w8LHnbap091466@repo.freebsd.org> <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v2fua2r66qnkigtm" Content-Disposition: inline In-Reply-To: <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net> X-Operating-System: FreeBSD mutt-hbsd 12.0-ALPHA5 FreeBSD 12.0-ALPHA5 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180622 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Sep 2018 18:24:29 -0000 --v2fua2r66qnkigtm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 21, 2018 at 01:11:46PM -0700, Xin Li wrote: > On 9/21/18 10:49, Ed Maste wrote: > > Author: emaste > > Date: Fri Sep 21 17:49:37 2018 > > New Revision: 338861 > > URL: https://svnweb.freebsd.org/changeset/base/338861 > >=20 > > Log: > > libc: require ifunc-capable linker for amd64/i386 > > =20 > > We expect to introduce optimized libc routines in the near future, > > which requires use of a linker that supports ifuncs. > > =20 > > Approved by: re (gjb, kib) > > Sponsored by: The FreeBSD Foundation > >=20 > > Modified: > > head/lib/libc/Makefile > >=20 > > Modified: head/lib/libc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/Makefile Fri Sep 21 17:44:05 2018 (r338860) > > +++ head/lib/libc/Makefile Fri Sep 21 17:49:37 2018 (r338861) > > @@ -21,6 +21,11 @@ LIBC_ARCH=3D${MACHINE_ARCH} > > LIBC_ARCH=3D${MACHINE_CPUARCH} > > .endif > > =20 > > +.if (${LIBC_ARCH} =3D=3D amd64 || ${LIBC_ARCH} =3D=3D i386) && \ > > + defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} =3D=3D "" > > +.error ${LIBC_ARCH} libc requires linker ifunc support > > +.endif > > + > > # All library objects contain FreeBSD revision strings by default; the= y may be > > # excluded as a space-saving measure. To produce a library that does > > # not contain these strings, add -DSTRIP_FBSDID (see ) to= CFLAGS >=20 > It seems that this would break bootstraping from a FreeBSD -CURRENT > before ifunc? It does. The HardenedBSD nightly build server is running 11-STABLE and now cannot build 12-CURRENT: https://jenkins.hardenedbsd.org/jenkins/job/HardenedBSD-CURRENT-amd64/1332/= console Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --v2fua2r66qnkigtm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlumiMkACgkQaoRlj1JF bu7vbQ//WyCQmmEuwZxvHDvVk8gTp/nBA3d9HFt+dRmBcGTH3+KUh55wfNVT7tSZ OZ/jeODWrxXhT3o9/+cpq/UVaWvNuXJdys1EKd+LYaRQ38BJsXLOhVkfiTojUPb5 wjOjnIBmnnfh8VKgR67wUvprEVR+BO3b1CnYQnQXuSicIM+TVWAbXiWASuRinGDF 7T3xMpy9XWgYTkyAzibqabgidKemVjvVsylUQK+AWeF4ZcX3X37DB55NQW4kOcuc 5u6RnsrHf08Gyk66meOY0sVGrNfmHWq78kWZk4Bh6Xr7xQa7b+21wrFqycKD6AbN rwBozcDsWWkZNJ+r7Tt/qs00KShr5yPUlRkb0cYUi8Q/LUSBdqwLNkxmKlEnSiqs k1u25Yua2cpLLwO2Rouza4yMTdvsHXQpRD0Hjdo+gjTYXyofY1hWpXIBIexzcCZY IE19k5aH5M9Fr5dTtl0xOSuQMw4qjuJb0EtywZQeXwVe/AU/fCDCsPFQAla6nZ86 hD5kNCn9BGI09L888OQ3sHUAdgRyVnG1D0UsFGqnwOgORgBuuxNjlRIYZPP5w1Si gqy8aq72AEHeIsCDXrW/h+H2uGVU6s06hyYXTb+l5W0DbaDoHlyXxpFLLPsuDFzb TKgpZAPo8oi2HqRm01GTRane8RGQ17Aqtg5aJV7jgivDvmGzVug= =dSP/ -----END PGP SIGNATURE----- --v2fua2r66qnkigtm--