From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Sep 4 15:30:11 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AECEF1065677 for ; Tue, 4 Sep 2012 15:30:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1D6B68FC14 for ; Tue, 4 Sep 2012 15:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q84FU8df049507 for ; Tue, 4 Sep 2012 15:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q84FU8s1049493; Tue, 4 Sep 2012 15:30:08 GMT (envelope-from gnats) Resent-Date: Tue, 4 Sep 2012 15:30:08 GMT Resent-Message-Id: <201209041530.q84FU8s1049493@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bryan Drewery Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D8BFA106564A for ; Tue, 4 Sep 2012 15:22:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A448F8FC0C for ; Tue, 4 Sep 2012 15:22:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q84FMpTU000651 for ; Tue, 4 Sep 2012 15:22:51 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q84FMp2G000628 for FreeBSD-gnats-submit@freebsd.org; Tue, 4 Sep 2012 15:22:51 GMT (envelope-from bdrewery) Received: (qmail 5640 invoked from network); 4 Sep 2012 10:22:43 -0500 Received: from unknown (HELO test8.xzibition.com) (10.10.0.34) by sweb.xzibition.com with SMTP; 4 Sep 2012 10:22:43 -0500 Received: by test8.xzibition.com (sSMTP sendmail emulation); Tue, 04 Sep 2012 10:22:42 -0500 Message-Id: <201209041522.q84FMp2G000628@freefall.freebsd.org> Date: Tue, 04 Sep 2012 10:22:42 -0500 From: Bryan Drewery To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: bapt@FreeBSD.org Subject: ports/171326: [PATCH] [Mk] Fix bogus warnings in bsd.openssl/ncurses.mk when using pkgng X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bryan Drewery List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 15:30:11 -0000 >Number: 171326 >Category: ports >Synopsis: [PATCH] [Mk] Fix bogus warnings in bsd.openssl/ncurses.mk when using pkgng >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Sep 04 15:30:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Bryan Drewery >Release: FreeBSD 8.3-RELEASE i386 >Organization: >Environment: >Description: If WITH_PKGNG is defined in make.conf, trying to install (or use pkg2ng) a port that depends on ports openssl or ncurses, the following warnings are produced: "/usr/ports/Mk/bsd.openssl.mk", line 109: warning: "/usr/local/sbin/pkg which -qo /usr/local/lib/libcrypto.so" returned non-zero status "/usr/ports/Mk/bsd.ncurses.mk", line 66: warning: "/usr/local/sbin/pkg which -qo /usr/local/lib/libncurses.so" returned non-zero status The value returned is blank and the mk files are already properly accounting for that. The only problem is the bogus warning. The patch makes the warning go away. >How-To-Repeat: # *No openssl/ncurses package registered in pkgng yet* # Already have security/openssl and devel/ncurses installed echo "WITH_PKGNG=yes" >> /etc/make.conf make -C /usr/ports/security/tor -VOPENSSL_PORT make -C /usr/ports/security/metasploit -VNCURSES_PORT >Fix: --- patch-mk-pkg-which.txt begins here --- diff -ur Mk.orig/bsd.ncurses.mk Mk/bsd.ncurses.mk --- Mk.orig/bsd.ncurses.mk 2012-05-06 08:54:57.000000000 -0500 +++ Mk/bsd.ncurses.mk 2012-09-04 10:20:05.000000000 -0500 @@ -63,7 +63,7 @@ .else PKGARGS= .endif -NCURSES_INSTALLED!= ${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libncurses.so +NCURSES_INSTALLED!= ${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libncurses.so || : .else NCURSES_INSTALLED!= find "${PKG_DBDIR}/" -type f -name "+CONTENTS" -print0 | \ xargs -0 grep -l "^lib/libncurses.so." | \ diff -ur Mk.orig/bsd.openssl.mk Mk/bsd.openssl.mk --- Mk.orig/bsd.openssl.mk 2012-04-18 06:38:20.000000000 -0500 +++ Mk/bsd.openssl.mk 2012-09-04 10:05:53.000000000 -0500 @@ -106,7 +106,7 @@ .else PKGARGS= .endif -OPENSSL_INSTALLED!= ${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libcrypto.so +OPENSSL_INSTALLED!= ${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libcrypto.so || : .else OPENSSL_INSTALLED!= find "${PKG_DBDIR}/" -type f -name "+CONTENTS" -print0 | \ xargs -0 grep -l "^lib/libssl.so." | \ --- patch-mk-pkg-which.txt ends here --- >Release-Note: >Audit-Trail: >Unformatted: