From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Dec 4 18:20:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4CCCC950 for ; Tue, 4 Dec 2012 18:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2F4D68FC15 for ; Tue, 4 Dec 2012 18:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qB4IK1F7038226 for ; Tue, 4 Dec 2012 18:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qB4IK1DQ038225; Tue, 4 Dec 2012 18:20:01 GMT (envelope-from gnats) Date: Tue, 4 Dec 2012 18:20:01 GMT Message-Id: <201212041820.qB4IK1DQ038225@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: "David O'Brien" Subject: Re: ports/174063 : [PATCH] misc/figlet-fonts: update to 20121202, take maintainership X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: David O'Brien List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2012 18:20:01 -0000 The following reply was made to PR ports/174063; it has been noted by GNATS. From: David O'Brien To: nemysis Cc: bug-followup@FreeBSD.org Subject: Re: ports/174063 : [PATCH] misc/figlet-fonts: update to 20121202, take maintainership Date: Tue, 4 Dec 2012 10:15:20 -0800 On Tue, Dec 04, 2012 at 07:05:28PM +0100, nemysis wrote: > On Tue, 4 Dec 2012 09:53:21 -0800 David O'Brien wrote: > > -# Generate pkg-plist from files/fontfiles. > > - > > -makelist: > > - ${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \ > > - > ${PLIST} > > > > I may have missed someting, but why remove this helper? > > The "share/figlet/" should be "%%DATADIR%%" instead. > > Yes this was faulty in old Port i use %%DATADIR%% in all mine Ports. I believe you're missing my point. Rather than delete all those lines, just make this change: - ${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \ + ${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;%%DATADIR%%/;' \ -- -- David (obrien@FreeBSD.org)