Date: Fri, 20 Jul 2001 00:14:29 +0200 From: Anton Berezin <tobez@tobez.org> To: "Jeroen C. van Gelderen" <jeroen@vangelderen.org> Cc: FreeBSD Stable <freebsd-stable@FreeBSD.ORG> Subject: Re: initgroups unsolicited warning? Message-ID: <20010720001429.A65236@heechee.tobez.org> In-Reply-To: <20010719234413.A64433@heechee.tobez.org>; from tobez@tobez.org on Thu, Jul 19, 2001 at 11:44:13PM %2B0200 References: <3B5713AB.79322FDA@vangelderen.org> <20010719234413.A64433@heechee.tobez.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 19, 2001 at 11:44:13PM +0200, Anton Berezin wrote: > Please see PR 15421. :-) > > On Thu, Jul 19, 2001 at 01:06:51PM -0400, Jeroen C. van Gelderen wrote: > > > Comments? Should I file this as a PR when I can reach the > > freebsd.org host again? I think I have more to say on the problem. I did not commit the obvious fix because there exist concerns about the rest of the base system that uses initgroups(3). The statistics for the relatively fresh -current sources is as follows. Here OK means that the caller checks initgroups() return code and acts appropriately. NOK means that initgroups() is called without return code checking. contrib/bind/bin/named/ns_main.c OK contrib/cvs/src/server.c OK contrib/opie/opieftpd.c NOK contrib/opie/opielogin.c NOK contrib/opie/opiesu.c OK contrib/sendmail/src/deliver.c OK contrib/sendmail/src/recipient.c OK crypto/heimdal/appl/ftp/ftpd/ftpd.c NOK crypto/heimdal/appl/kauth/kauthd.c OK crypto/heimdal/appl/login/login.c OK crypto/heimdal/appl/rsh/rshd.c OK crypto/heimdal/appl/su/su.c OK crypto/kerberosIV/appl/bsd/login.c NOK crypto/kerberosIV/appl/bsd/rshd.c NOK crypto/kerberosIV/appl/bsd/su.c OK crypto/kerberosIV/appl/ftp/ftpd/ftpd.c NOK crypto/kerberosIV/appl/kauth/kauthd.c OK crypto/openssh/session.c OK crypto/openssh/uidswap.c OK lib/libutil/login_class.c OK libexec/atrun/atrun.c OK libexec/ftpd/ftpd.c NOK libexec/rexecd/rexecd.c NOK libexec/uucpd/uucpd.c NOK usr.bin/calendar/calendar.c NOK usr.sbin/cron/cron/do_command.c NOK usr.sbin/cron/cron/popen.c NOK usr.sbin/inetd/builtins.c OK usr.sbin/inetd/inetd.c NOK usr.sbin/lpr/lpd/printjob.c NOK I.e., 14 out of 30 C files do not do the right thing, and must be fixed before the fix gets committed. The problem is worse than it seems to be since in about the half of `NOK' source files, when one centers the editor view around initgroups() call, there are other rather important libc functions/syscalls that are called without any checks; it would not be interesting to fix initgroups() call and to not fix, say, setgrp() call at the same time. I was planning to take care of it in the late July or probably August, but feel free to do so before if you wish. \Anton. -- May the tuna salad be with you. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010720001429.A65236>