From owner-cvs-src@FreeBSD.ORG  Thu Apr 10 11:29:30 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 244D537B401; Thu, 10 Apr 2003 11:29:30 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C7E8243FA3; Thu, 10 Apr 2003 11:29:28 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h3AITQA7021200;
	Thu, 10 Apr 2003 12:29:26 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 10 Apr 2003 12:29:06 -0600 (MDT)
Message-Id: <20030410.122906.62350043.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <Pine.BSF.4.21.0304101114320.31875-100000@root.org>
References: <20030410051257.D296537B408@hub.freebsd.org>
	<Pine.BSF.4.21.0304101114320.31875-100000@root.org>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c
 if_an_pci.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Apr 2003 18:29:30 -0000

In message: <Pine.BSF.4.21.0304101114320.31875-100000@root.org>
            Nate Lawson <nate@root.org> writes:
: > @@ -817,9 +806,11 @@
: >  	 */
: >  	ether_ifattach(ifp, sc->arpcom.ac_enaddr);
: >  	callout_handle_init(&sc->an_stat_ch);
: > -	AN_UNLOCK(sc);
: >  
: >  	return(0);
: > +fail:;
: > +	mtx_destroy(&sc->an_mtx);
: > +	return(error);
: >  }
: >  
: >  static void
: 
: Extra ; after "fail:"

I feel that it isn't a mistake.  A label labels a statement, and this
label labels a null statement on purpose in case the statements after
it disappear.

: > @@ -176,18 +176,26 @@
: >  	an_alloc_port(dev, sc->port_rid, AN_IOSIZ);
: >  	an_alloc_irq(dev, sc->irq_rid, 0);
: 
: You should probably check the return values of these.

Yea.  Likely.  The old driver didn't check, so I don't bother to check
them myself.

Warner