From owner-freebsd-acpi@FreeBSD.ORG  Fri Feb 12 19:09:55 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id CDE9C1065697;
	Fri, 12 Feb 2010 19:09:55 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-acpi@FreeBSD.org
Date: Fri, 12 Feb 2010 14:09:47 -0500
User-Agent: KMail/1.6.2
References: <alpine.BSF.2.00.1002121840460.1675@mini-beast>
	<201002121320.51441.jkim@FreeBSD.org>
	<alpine.BSF.2.00.1002121928590.1675@mini-beast>
In-Reply-To: <alpine.BSF.2.00.1002121928590.1675@mini-beast>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201002121409.49779.jkim@FreeBSD.org>
Cc: Daniel Walter <D.Walter@student.uibk.ac.at>,
	Daniel Walter <d.walter@0x90.at>
Subject: Re: Call for testers acpi_dell
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Feb 2010 19:09:56 -0000

On Friday 12 February 2010 01:33 pm, Daniel Walter wrote:
> On Fri, 12 Feb 2010, Jung-uk Kim wrote:
> > On Friday 12 February 2010 12:48 pm, Daniel Walter wrote:
> >> Hi all,
> >>
> >> I've written a small kernel driver to support Dell Mini 1011
> >> (aka Dell Mini 10v) Brightness Controll Buttons. Since I do not
> >> have any other Dell Notebooks, I'd like you to test this module
> >> on other Dell Notebooks as well.
> >>
> >> This driver is in an early stage, but future releases will also
> >> support the rfkill switch and CRT switch.
> >>
> >> Currently following features are implemented:
> >> * Increase / Decrease Brightness
> >> * Change brightness if AC is connected / disconnected
> >>
> >> TODO:
> >> * Add CRT Support
> >> * Add Sysctl to define brightness levels for eco and ac
> >> powerprofile * Add Support for RF-Kill Switch
> >>
> >> Any suggestions are welcome
> >
> > I just quickly glanced at it but I failed see anything quite
> > specific to Dell laptops except for "TODO: Add support for
> > RF-Kill Switch". acpi_video(4) should be able to do what you
> > want.  Am I missing something here?
> >
> > Jung-uk Kim
>
> hi,
>
> Yes it is possible to control the brightness using acpi_video(4)
> via sysctl but there is no support for the FN-Buttons. This module
> adds the support for those buttons.

I see.  However, my point is the probe function does not seem specific 
to Dell laptops.  In fact, you are just checking _BCL transition, 
i.e., effectively it just makes a generic acpi_video notify handler 
for brightness change.

Jung-uk Kim