From owner-freebsd-current@FreeBSD.ORG Wed Jul 30 00:37:59 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCB9F37B401 for ; Wed, 30 Jul 2003 00:37:58 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE64443FA3 for ; Wed, 30 Jul 2003 00:37:54 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6U7bT0U042548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Jul 2003 10:37:30 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6U7bTvo042547; Wed, 30 Jul 2003 10:37:29 +0300 (EEST) (envelope-from ru) Date: Wed, 30 Jul 2003 10:37:29 +0300 From: Ruslan Ermilov To: John Birrell Message-ID: <20030730073729.GC37041@sunbay.com> References: <20030730113026.B18842@freebsd1.cimlogic.com.au> <20030730021209.0461F2A7EA@canning.wemm.org> <20030730072442.GA37041@sunbay.com> <20030730173400.H18842@freebsd1.cimlogic.com.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O3RTKUHj+75w1tg5" Content-Disposition: inline In-Reply-To: <20030730173400.H18842@freebsd1.cimlogic.com.au> User-Agent: Mutt/1.5.4i cc: current@FreeBSD.org Subject: Re: Who is responsible for the install check goo in Makefile.inc1 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2003 07:37:59 -0000 --O3RTKUHj+75w1tg5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 30, 2003 at 05:34:01PM +1000, John Birrell wrote: > On Wed, Jul 30, 2003 at 10:24:42AM +0300, Ruslan Ermilov wrote: > > I'm regularly upgrading 4.0-RELEASE to 5.x-CURRENT to check that > > the upgrade path wasn't broken, and this check comes very handy. > > I wouldn't object though if it was done using kern.osreldate. > >=20 > > I'd happily test any patches in this direction for you, John. >=20 > Thanks. Since Peter made the change, I'd like to wait for him to comment > on the code I sent him that would avoid the core dump. I think that runni= ng > sh as a final check is valid, but I'd like to see a 'probable' case check= ed > first and an message printed accordingly before making the core dump as a > last resort (in favour of shooting the whole foot off - one toe is better > than the whole foot!). >=20 Sure, that would be a much better (and safer) approach. Could you please send me your code as well, I'm interested in revieweing it. P.S. Nice to see you're still in the FreeBSD business. :-) Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --O3RTKUHj+75w1tg5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/J3W5Ukv4P6juNwoRAo3OAJ9E4DAMGNxEfPx6G0NvKvYg38GZqQCeNpDf HWr3huJuZHKVUabTL/bMaU4= =iFW/ -----END PGP SIGNATURE----- --O3RTKUHj+75w1tg5--