From owner-freebsd-ports@FreeBSD.ORG Sat Jan 17 14:09:42 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F5B5C2E; Sat, 17 Jan 2015 14:09:42 +0000 (UTC) Received: from mail-wg0-x236.google.com (mail-wg0-x236.google.com [IPv6:2a00:1450:400c:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D979C47; Sat, 17 Jan 2015 14:09:41 +0000 (UTC) Received: by mail-wg0-f54.google.com with SMTP id z12so24860609wgg.13; Sat, 17 Jan 2015 06:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ekKel2rLZE04V0MAgV32llfOQ9hzx25FZ+0aCGNlXrg=; b=jAl+aLI1KaqRfM66erfKiEMZrtGp5/TH/3cr/f6ekMU8qDzdY9oBnqFQ54SXEEUQ8x 4ScbdMwoyOtE7hohEWk/Fw93LCol5x8Vg5j5P3eTs+O0r08yr8/S+oDFZR/c7Zuy7JRo MegNIGzKfIobSqEZSfeKrrDrrqI4i7OxrqGltO7ydrMQKc751beitvN/KYucMHhQPGj6 r8cYLJPs82Z1w4sGTbrfisnFAy3S6Qa9PGnQoYWbqXjPpnDtJP2zQM2QFKLlciytYTh3 xQ8mPM1J/yG2aYuODHylIP2weLFq1FCL4eMkRwpiQP3uhEfclvJyt+SQEBmkRaqhhYwF y9ow== X-Received: by 10.180.72.178 with SMTP id e18mr16034023wiv.23.1421503779622; Sat, 17 Jan 2015 06:09:39 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id vh8sm9917743wjc.12.2015.01.17.06.09.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Jan 2015 06:09:38 -0800 (PST) Sender: Baptiste Daroussin Date: Sat, 17 Jan 2015 15:09:36 +0100 From: Baptiste Daroussin To: Palle Girgensohn Subject: Re: postgresql93 port and libedit Message-ID: <20150117140935.GQ98528@ivaldir.etoilebsd.net> References: <20150115160113.GE98528@ivaldir.etoilebsd.net> <20150117004151.GO98528@ivaldir.etoilebsd.net> <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pes7OZCOzfZhFQfq" Content-Disposition: inline In-Reply-To: <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "pgsql@FreeBSD.org" , "freebsd-ports@freebsd.org" , Waitman Gobble X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2015 14:09:42 -0000 --Pes7OZCOzfZhFQfq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 17, 2015 at 10:37:49AM +0100, Palle Girgensohn wrote: >=20 >=20 > 17 jan 2015 kl. 01:41 skrev Baptiste Daroussin : >=20 > > On Thu, Jan 15, 2015 at 08:02:22PM -0800, Waitman Gobble wrote: > >> On Thu, Jan 15, 2015 at 8:01 AM, Baptiste Daroussin = wrote: > >>> On Wed, Jan 14, 2015 at 10:27:14PM -0800, Waitman Gobble wrote: > >>>> Hi, > >>>>=20 > >>>> I noticed that postgresql93-client port pulls in readline, which is = GPLv3. > >>>> When I get rid of readline in Makefile 'USES' and also change the > >>>> bottom of the Makefile in postgresql93-server, > >>>>=20 > >>>> ... > >>>> .include "${.CURDIR}/../postgresql92-server/Makefile" > >>>>=20 > >>>> CONFIGURE_ARGS+=3D--with-libedit-preferred > >>>>=20 > >>>>=20 > >>>> It builds without readline and links against libedit in base: > >>>>=20 > >>> except that libedit is not really an alternative as it does not suppr= ot unicode > >>> (except in head) one solution would be to try linking against the edi= tline port > >>> which contains the same fixes as libedit in head and see if it works. > >>>=20 > >>> Best regards, > >>> Bapt > >>=20 > >> Thanks so much for the feedback. I've considered the options regarding > >> my project and I think it's more work to handle end-user devices with > >> a pkg repository if I indeed must manage custom ports built using > >> customized sources. Distributing the initial appliance isn't the > >> problem, i'm working out an update strategy for down the road. > >>=20 > >=20 > > https://people.freebsd.org/~bapt/pglibedit.diff > >=20 > > This patch works for me and accepts perfectly unicode. > >=20 > > Can anyone from the postgresql team test, generalize to other postegres= ql > > versions? (please keep it using the port version of libedit). > >=20 > > Best regards, > > Bapt >=20 > Hi, >=20 > Looks like a reasonable patch. I have a hard time finding the differences= between readine and ilbedit. It aims at 100% API compatibility. How good i= s libedit? If it degrades functionality compared to readline it should real= ly be an option, but I agree, lesser options are preferred.=20 >=20 > Palle It is not 100% compatible but I think it implements all pgsql requirements,= only the version in ports and he head handle correctly unicode. Some of the default settings are a bit different most ^W but that can be ch= anged via .editrc mysql has tips about the differences: https://docs.oracle.com/cd/E17952_01/refman-5.6-en/mysql-tips.html =46rom what I can read in the code psql only uses compatible interfaces. As the one who have done the latet updates on libedit both base and ports, I would recommand to only use the version from ports on all version of FreeBS= D as I can add quick fixes if needed. Once I'm sure the libedit in base is good enough everywhere we would be abl= e to switch on the base version if people prefers to avoid an external dep. Best regards, Bapt --Pes7OZCOzfZhFQfq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlS6bR0ACgkQ8kTtMUmk6EwAIwCfRLBwBfzzBlxaucaBfUMU0d0f KcgAnjKATPDAJ0szNqQ6FrnOLjixYpbV =rudY -----END PGP SIGNATURE----- --Pes7OZCOzfZhFQfq--