From owner-freebsd-fs@FreeBSD.ORG Thu Aug 14 01:11:03 2008 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F611106568B for ; Thu, 14 Aug 2008 01:11:03 +0000 (UTC) (envelope-from tbourke@triptrop.cse.unsw.edu.au) Received: from tone.orchestra.cse.unsw.EDU.AU (tone.orchestra.cse.unsw.EDU.AU [129.94.242.59]) by mx1.freebsd.org (Postfix) with ESMTP id B11738FC08 for ; Thu, 14 Aug 2008 01:11:02 +0000 (UTC) (envelope-from tbourke@triptrop.cse.unsw.edu.au) Received: From triptrop.cse.unsw.edu.au ([129.94.175.153]) (for ) By tone With Smtp ; Thu, 14 Aug 2008 10:55:54 +1000 Received: from triptrop.cse.unsw.edu.au (localhost [127.0.0.1]) by triptrop.cse.unsw.edu.au (8.14.2/8.13.6) with ESMTP id m7E0qAVZ001288 for ; Thu, 14 Aug 2008 10:52:10 +1000 (EST) (envelope-from tbourke@triptrop.cse.unsw.edu.au) Received: (from tbourke@localhost) by triptrop.cse.unsw.edu.au (8.14.2/8.13.6/Submit) id m7E0qAP4001287 for fs@freebsd.org; Thu, 14 Aug 2008 10:52:10 +1000 (EST) (envelope-from tbourke) From: Timothy Bourke To: fs@freebsd.org Date: Thu, 14 Aug 2008 10:52:10 +1000 Message-ID: <20080814005210.GB1057@triptrop.cse.unsw.EDU.AU> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SkvwRMAIpAhPCcCJ" Content-Disposition: inline X-PGP-Key: http://www.cse.unsw.edu.au/~tbourke/pubkey.txt User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Subject: msdosfs for an iriver x20 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 01:11:03 -0000 --SkvwRMAIpAhPCcCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The iriver x20 portable media player in MSC mode is detected by the umass driver but the internal flash memory cannot be mounted (7.6GB FAT32 filesystem on an unsliced disk) under 6.3-RELEASE. The msdos file system routines detect: pmp->pm_SecPerTrack=64 (0x40) The patch below fixes the problem. It looks like HEAD contains more general improvements that should also work but RELENG_6 does not. Would it be worth MFCing the new changes or committing the attached patch before the 6.4 release? Tim. --- sys/fs/msdosfs/msdosfs_vfsops.c.orig 2008-08-14 09:43:06.000000000 +1000 +++ sys/fs/msdosfs/msdosfs_vfsops.c 2008-08-14 09:43:19.000000000 +1000 @@ -504,7 +504,7 @@ #ifdef PC98 || !pmp->pm_SecPerTrack || pmp->pm_SecPerTrack > 255) { #else - || !pmp->pm_SecPerTrack || pmp->pm_SecPerTrack > 63) { + || !pmp->pm_SecPerTrack || pmp->pm_SecPerTrack > 64) { #endif error = EINVAL; goto error_exit; --SkvwRMAIpAhPCcCJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIo4G6tKVK1sFb0ecRAjy6AJ4qmNNUE6p0l+HrpIJHxNewCfnwqQCfY/BI qaVromzlgIDZR5M12IXjP7w= =F7VL -----END PGP SIGNATURE----- --SkvwRMAIpAhPCcCJ--