Date: Sun, 2 Aug 2009 17:05:30 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Ed Schouten <ed@80386.nl> Cc: FreeBSD Current <current@freebsd.org> Subject: Re: HEAD tty seems to drop characters Message-ID: <20090802140530.GJ1884@deviant.kiev.zoral.com.ua> In-Reply-To: <20090802123108.GY1292@hoeg.nl> References: <20090802105033.GG1884@deviant.kiev.zoral.com.ua> <20090802123108.GY1292@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--pVmaXEaLnySzRbTt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 02, 2009 at 02:31:08PM +0200, Ed Schouten wrote: > Hi Kostik, >=20 > * Kostik Belousov <kostikbel@gmail.com> wrote: > > I run a screen(1), where I tried to copy large portion of output and > > paste it into vi. This resulted in the loss of the characters at random > > points inside the pasted text. >=20 > I already took some time to investigate the issue. I have attached a > patch that should already improve the situation: >=20 > - write() on a pseudo-terminal master also accounted the data that was > read into the kernel, but couldn't be passed to the TTY (which is > likely to happen in non-blocking mode). >=20 > - There was also a small unrelated issue; input on a TTY which has been > configured in block (bypass) mode wouldn't set the input high water > mark. >=20 > For some reason, the data loss doesn't occur when SSHing to myself > multiple times, but still causes screen(1) to drop some bytes later on. >=20 > Even though it's always very easy to blame other applications, I suspect > this may be because I reduced the input buffer size from 8 KB to 2 KB > per pseudo-terminal. Maybe screen(1) can't deal with this. To be > investigated... At least, it is an improvement for me. Patch looks good. Please consider this as an approval for the commit. --pVmaXEaLnySzRbTt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkp1nSoACgkQC3+MBN1Mb4grTACgp/CY9nfAXFa+jege5EzEyZOq PdgAoKWkx0bQvPEpCeRCxdOA1sX0iBpd =Mssb -----END PGP SIGNATURE----- --pVmaXEaLnySzRbTt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090802140530.GJ1884>