From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 16 19:20:50 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BDAE16A4E7 for ; Mon, 16 Oct 2006 19:20:50 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7A6343D53 for ; Mon, 16 Oct 2006 19:20:30 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9GJKUmG077434 for ; Mon, 16 Oct 2006 19:20:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9GJKUv7077433; Mon, 16 Oct 2006 19:20:30 GMT (envelope-from gnats) Date: Mon, 16 Oct 2006 19:20:30 GMT Message-Id: <200610161920.k9GJKUv7077433@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: John Baldwin Cc: Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Baldwin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2006 19:20:50 -0000 The following reply was made to PR kern/104436; it has been noted by GNATS. From: John Baldwin To: freebsd-hackers@freebsd.org Cc: Bruce Evans , Cheng-Lung Sung , freebsd-current@freebsd.org, freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h Date: Mon, 16 Oct 2006 14:31:24 -0400 On Sunday 15 October 2006 11:21, Bruce Evans wrote: > On Sun, 15 Oct 2006, Cheng-Lung Sung wrote: > > > System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu May 11 14:31:45 CST 2006 root@FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD i386 > > > >> Description: > > - sys/sem.h has included sys/ipc.h, which includes sys/_types.h > > but it (and its including files) does not include sys/types.h > > - therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;" ...etc > > - if we only compile a program which do not include sys/types.h, it will fail. > > Including sys/types.h would add lots of namespace pollution which > sys/ipc.h and sys/sem.h are trying hard to avoid. sem.h is trying too > hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t, > which it already declares). Is this better? Index: sem.h =================================================================== RCS file: /usr/cvs/src/sys/sys/sem.h,v retrieving revision 1.29 diff -c -r1.29 sem.h *** sem.h 17 Nov 2004 13:12:06 -0000 1.29 --- sem.h 16 Oct 2006 18:30:05 -0000 *************** *** 111,116 **** --- 111,121 ---- #define _SIZE_T_DECLARED #endif + #ifndef _TIME_T_DECLARED + typedef __time_t time_t; + #define _TIME_T_DECLARED + #endif + #ifndef _PID_T_DECLARED typedef __pid_t pid_t; #define _PID_T_DECLARED (it looks like pid_t should be before size_t in sem.h btw) -- John Baldwin