From owner-cvs-src@FreeBSD.ORG Thu Jun 26 10:14:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F17A937B408 for ; Thu, 26 Jun 2003 10:14:28 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 6999C43FDF for ; Thu, 26 Jun 2003 10:14:27 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 74976 invoked by uid 1000); 26 Jun 2003 17:14:28 -0000 Date: Thu, 26 Jun 2003 10:14:28 -0700 (PDT) From: Nate Lawson To: Maxime Henrion In-Reply-To: <20030626132750.0BEB537B490@hub.freebsd.org> Message-ID: <20030626101347.F74937@root.org> References: <20030626132750.0BEB537B490@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ep if_ep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 17:14:29 -0000 On Thu, 26 Jun 2003, Maxime Henrion wrote: > Fix a race condition that was introduced since pccbb interrupts are > flag'ed INTR_MPSAFE. In ep_if_start(), use the IF_DEQUEUE macro to > grab the next mbuf to send, and use IF_PREPEND if the card is busy > and we actually can't handle it right now. > > The old code was first getting the mbuf by taking it from the queue > without using the macros, thus without locking, and without removing > it from the queue either. It was later assuming that IF_DEQUEUE would > give him this same mbuf. > > Tested by: mich > > Revision Changes Path > 1.115 +5 -7 src/sys/dev/ep/if_ep.c Nice debugging! (bus(9) for this driver coming soon? :) -Nate