From owner-freebsd-current@FreeBSD.ORG  Fri Sep  2 05:23:17 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 20096106564A;
	Fri,  2 Sep 2011 05:23:17 +0000 (UTC)
	(envelope-from rmh.aybabtu@gmail.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id D48618FC08;
	Fri,  2 Sep 2011 05:23:16 +0000 (UTC)
Received: by iadx2 with SMTP id x2so3576649iad.13
	for <multiple recipients>; Thu, 01 Sep 2011 22:23:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=q8vjr85sHJFfYoBtFDS9zAfyl2U56mSAdz8NdpbCwes=;
	b=TtnqO3kxpkCxGyPLu9CU0H2lGTdz1xtScQ9cTOyrbUu9eDo0IodmLPvDCpsJ8GavaK
	+lr3CUYMCnZT8xl+5MmMPueKIDEWoH342IFUFZp36BftK0JF5ZhYgTDJC+N5Emfwl/0P
	7jxQ78lFu/qtaj/hCr3EZMX5MgT6RJhn2/J3Q=
MIME-Version: 1.0
Received: by 10.42.138.9 with SMTP id a9mr498498icu.289.1314940996375; Thu, 01
	Sep 2011 22:23:16 -0700 (PDT)
Sender: rmh.aybabtu@gmail.com
Received: by 10.43.132.65 with HTTP; Thu, 1 Sep 2011 22:23:16 -0700 (PDT)
In-Reply-To: <201109011728.13979.jhb@freebsd.org>
References: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com>
	<201109011728.13979.jhb@freebsd.org>
Date: Fri, 2 Sep 2011 07:23:16 +0200
X-Google-Sender-Auth: 1bpLRh6p7x8dyFqtkFY73705aVI
Message-ID: <CAOfDtXMy+8pmNhRODwmutXUtrbmYgv-0cwdF8dR_AkkM=uQf4g@mail.gmail.com>
From: Robert Millan <rmh@debian.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Mailman-Approved-At: Fri, 02 Sep 2011 11:34:16 +0000
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] Fix NKPT kernel config option
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2011 05:23:17 -0000

2011/9/1 John Baldwin <jhb@freebsd.org>:
> In general we force the relevant C files to use opt_*.h includes and avoid
> nested includes of those in headers.

With this approach I can't trust that this feature will do the right
thing.  I would rather modify pmap.h by hand than run the unnecessary
risk.

> Do you know of any C files that do
> are using NKPT (or values derived from it) without including opt_pmap.h?

Many.  To obtain a full list, I suggest you put something like:

#ifdef NKPT
#warning nkpt:good
#else
#warning nkpt:bad
#endif

in pmap.h and build with "WERROR="

-- 
Robert Millan