From nobody Thu Nov 10 14:01:06 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N7Nm35KdKz4dYZy; Thu, 10 Nov 2022 14:01:07 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N7Nm34ntzz4DkH; Thu, 10 Nov 2022 14:01:07 +0000 (UTC) (envelope-from matteo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668088867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TkXZPz9zvgPVZpI+LBRDm1KUkb16oXHZ/mG8Cyy6WaU=; b=E0KLotX/D2KGPJlvwYtivEDPjZA5Fsv65bGq7uE/2OOzKmDd9bpZaUq+o53eRH9A5NgZUG 4w8Rq2rmBZ74s62ar74TqiGseSho0qxXDZOF59sWZcBJ3idr5ZyF2pAhwsTftDlUYIE8Vb MSaupj0eI49fzblSCpqRT5AJifK74u4AVh6aTTTK1mwucHgf66MjHHnoMPQPPkgVMXZiF0 fuBMQXwBrvAdTAlSmxZsfptrSuVBx0GKBqILEDEd9HuU3fRcGKjT6U6jZ+QXbOvZVi2yGV bOiCGs+FuOwbwcouRyqjc8ddImjhc9g3R9EI3alDAJTECgiY5vgzmTs+XNUI7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668088867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TkXZPz9zvgPVZpI+LBRDm1KUkb16oXHZ/mG8Cyy6WaU=; b=e5THGmRNdW88edAd4SEOQLPnLLf+AfFyLsmy4vw59KM3pdG/qs+Fqhwec3avAv8+HjyYqP ePS/8kl7zU+Tg9jzDxZ5hlihR91KXd3a3pt8LvzZiSQPSlEkg/C+dwmsIjIBGHw6Z4Eo/I Xm9vi7E6YV4stZZSgsVfwmsYFaM4c0FtEdAHPJt6N5Hurg9Ri4xh5uC8/0mpqv7xeyZv8v BRv3OFCR090rCVoce54M/e2VPyQTwb0K67s2sZkYqQRyFTJEGrMKyYXfuz7EiYBuZZw7WJ bvMnz92tpL7S4bO4m4vHgMIGHoiuYYg7K1bJYFlHZtYDYNZNXDJEXKnIflsN8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668088867; a=rsa-sha256; cv=none; b=nt1B2p2B8B2BAr7IXwFOZqlJXZumfmEZ0S3SXfmPRWU1qFxKE4vcXpvM8xWKcA3FAN0B8l nONIGcNaevd6hfTSNKh0Cjw/oK9AwTMVmVcKluPoqFLPeSmr6ZUKpG7OjJu+D2XtKxX+rD m5BVuC6KceGMmuM60ybfwM9HJgJ/u47cmiiV5++DiMihZHXBdiVAhUJutVPZzyiZcGHb+K 34auxK2BWp0wHBkrI6ipbn8BOhnhSAjKkCFeyyTp/OcoV6ZxaBjdd3m7yiVO2UWw8xcR+Q UcxsoGrhNHQPVsKX3zldW1p5b/PwXcQqL6wNqQg+LLd9zI1iG1VZh+5NTbcjYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ubertino.local (unknown [IPv6:2601:19b:4400:1779::1042]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: matteo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4N7Nm32mMXzY99; Thu, 10 Nov 2022 14:01:07 +0000 (UTC) (envelope-from matteo@freebsd.org) Date: Thu, 10 Nov 2022 09:01:06 -0500 From: Matteo Riondato To: Baptiste Daroussin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0b1adc42a15c - main - rc.sendmail: remove unused script Message-ID: <20221110140106.rwup6yssxwaikp4d@ubertino.local> X-PGP-Key: http://rionda.to/files/matteogpg.asc References: <202211091557.2A9FvdQ4072042@gitrepo.freebsd.org> <20221109174947.ykci234inrgiz7wi@ubertino.local> <4C690EC7-3D87-416B-934F-452801EE0EC8@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oec7tlv2q73tdo3s" Content-Disposition: inline In-Reply-To: <4C690EC7-3D87-416B-934F-452801EE0EC8@FreeBSD.org> X-ThisMailContainsUnwantedMimeParts: N --oec7tlv2q73tdo3s Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-11-09 at 14:29 EST, Baptiste Daroussin wrote: >Le 9 novembre 2022 18:49:47 GMT+01:00, Matteo Riondato=20 > a =E9crit=A0: >>The one lingering issue I see is that there is now no documentation=20 >>for the rc.conf sendmail_* variables: they were documented in=20 >>rc.sendmail.8 and rc.conf.5 referred to it, but your previous commit=20 >>6a2d6a569b1350f46998a2446fc89059b160fd13 removed that reference from=20 >>rc.conf.8, and this commit removes rc.sendmail.8. >> >>(Sorry for the noise if you're already working on it). > >I prefer too much noise than something forgotten in silence and=20 >actually this is no noise > >Such documentation is supposed to be in rc.conf(5). It would probably=20 >be a good idea to push the documentation there. > >If someone is interested be my guest, otherwise I will look into it in=20 >the next couple of weeks. Thank you for taking care of this one so quickly. A few rough corners I still see: 1) sendmail_cert_create should perhaps be set to NO in rc.conf, or the=20 call to sendmail_cert_create() in rc.d/sendmail should also depend on=20 some form of sendmail being enabled. The former action seems easier. 2) the role of rc.d/othermta is quite bizarre, especially now that it=20 checks for a non-existing script (/etc/rc.sendmail). I wonder whether it=20 should be retired, together with the rc.conf variable mta_start_script=20 (which now is set to a non-existing script). It feels like a relic from=20 a long gone past. 3) the comments on some of the sendmail_* variables in rc.conf mention a=20 generic "MTA", but perhaps they should say "sendmail", as that's not the=20 one-and-only MTA. Thanks, Matteo --oec7tlv2q73tdo3s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmNtBB4TGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAVEvD/9Zu2wRNzX11M8aKI9XTPg13gwl41Z9 qNlKkEN04vS0j49YdaKPasiWbkXk6/vy5oj9PDKWD28jLJQCtKRcGOkloplh4AVX JJftGG9uKt+LmVbqp9afG/TJ+e4iaJVnc3Hm3YTF7711tVjD3K4AMKfsdHCIZVn2 /ZmCcAzzAhhBJdSDYWXJZQAdzihrikPPzhAgeC7qhjJhd/viEkX62MhrjLoR1qoQ OLJi1GRQM5b1Lqfhk6PhRJk2JbHrWwjU4V3IDoNi27+iGMwpFz2xoDPNqE3odtaN ywR0jCBBoFt4iI8X18VQsM0m6zgwL/aJ/Go8RG8AOo4AmGR852fl4cVdLVOJhX/o 5B1BRsJ/Gbuh9/RngZgZ+e9VotsO5auVDCyJQMCDfXso2iTp4bpHhyZl+wKZFoK3 OiO6+wtnQQ/J4T+fciBc7NUceMy4GFkZGRtshZGpHD/vevi1MNiVgnSq1qRAOXzy giJWK6HRmhIr8I7pPS1QwRPo2qIRbCeTfIiJn0btpifcliA3WPmg2wnYoFCur5o9 lMdL5e4b3ScvDEpLO9oMdOcyriGGeVbPH325XigPCtnWiJeWqEoFEcLb3QijL+/Q 4zVA/qs0eRjFHxRwpqnZEhBVTH0PkJwIgyhxfBpw8SUJsB7JtwYS9QsrW7h785lc vyeyG69j4J2EWw== =eQaC -----END PGP SIGNATURE----- --oec7tlv2q73tdo3s--