From owner-freebsd-current@FreeBSD.ORG Wed Jan 28 04:48:54 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 729AE16A4CE for ; Wed, 28 Jan 2004 04:48:54 -0800 (PST) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBD2643D39 for ; Wed, 28 Jan 2004 04:48:50 -0800 (PST) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id B78A1530D; Wed, 28 Jan 2004 13:48:49 +0100 (CET) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id E63F85308; Wed, 28 Jan 2004 13:48:39 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 2602) id 77C2933C6A; Wed, 28 Jan 2004 13:48:39 +0100 (CET) To: Eric van Gyzen References: <200401272017.31161.vangyzen@stat.duke.edu> From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Wed, 28 Jan 2004 13:48:39 +0100 In-Reply-To: <200401272017.31161.vangyzen@stat.duke.edu> (Eric van Gyzen's message of "Tue, 27 Jan 2004 20:19:06 -0500") Message-ID: User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on flood.des.no X-Spam-Level: ss X-Spam-Status: No, hits=2.6 required=5.0 tests=RCVD_IN_DYNABLOCK, RCVD_IN_SORBS autolearn=no version=2.61 cc: freebsd-current@freebsd.org Subject: Re: libexec/ftpd/ftpd.c and pam X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2004 12:48:54 -0000 Eric van Gyzen writes: > The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable > pam_handle_t *pamh =3D NULL; > which shadows the same variable in the global scope. This seems=20 > unintentional, because the global pamh is never initialized by pam_start(= ),=20 > so the other functions in ftpd.c always operate on a NULL pam_handle_t. you're right... though the only impact is that pam_open_session() never gets called. Could you please file a PR and Cc: me? DES --=20 Dag-Erling Sm=F8rgrav - des@des.no