Date: Wed, 28 Jan 2004 13:48:39 +0100 From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) To: Eric van Gyzen <vangyzen@stat.duke.edu> Cc: freebsd-current@freebsd.org Subject: Re: libexec/ftpd/ftpd.c and pam Message-ID: <xzpektkme6w.fsf@dwp.des.no> In-Reply-To: <200401272017.31161.vangyzen@stat.duke.edu> (Eric van Gyzen's message of "Tue, 27 Jan 2004 20:19:06 -0500") References: <200401272017.31161.vangyzen@stat.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Eric van Gyzen <vangyzen@stat.duke.edu> writes: > The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable > pam_handle_t *pamh =3D NULL; > which shadows the same variable in the global scope. This seems=20 > unintentional, because the global pamh is never initialized by pam_start(= ),=20 > so the other functions in ftpd.c always operate on a NULL pam_handle_t. you're right... though the only impact is that pam_open_session() never gets called. Could you please file a PR and Cc: me? DES --=20 Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpektkme6w.fsf>