From owner-p4-projects@FreeBSD.ORG Tue Nov 8 11:44:10 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A0AE816A421; Tue, 8 Nov 2005 11:44:09 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AD7316A41F; Tue, 8 Nov 2005 11:44:09 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C3C843D68; Tue, 8 Nov 2005 11:44:02 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id C7CDF51CD1; Tue, 8 Nov 2005 12:44:00 +0100 (CET) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9396850F92; Tue, 8 Nov 2005 12:43:52 +0100 (CET) Date: Tue, 8 Nov 2005 12:43:43 +0100 From: Pawel Jakub Dawidek To: Todd Miller Message-ID: <20051108114343.GA10509@garage.freebsd.pl> References: <200511072145.jA7Lj66J026949@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <200511072145.jA7Lj66J026949@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 86437 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 11:44:10 -0000 --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2005 at 09:45:06PM +0000, Todd Miller wrote: +> http://perforce.freebsd.org/chv.cgi?CH=3D86437 +>=20 +> Change 86437 by millert@millert_ibook on 2005/11/07 21:44:18 +>=20 +> fix typo introduced in previous rev +>=20 +> Affected files ... +>=20 +> .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_a= v.c#6 edit +>=20 +> Differences ... +>=20 +> =3D=3D=3D=3D //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin= /ss/mach_av.c#6 (text+ko) =3D=3D=3D=3D +>=20 +> @@ -82,7 +82,7 @@ +> if (mcl =3D=3D NULL) +> return 0; +> =20 +> - cl =3D msgid-mcl->baseid / (8 * sizeof(access_vector_t)); +> + cl =3D (msgid-mcl - >baseid) / (8 * sizeof(access_vector_t)); That's a hard to read line of code:) I think this is a bit easier: cl =3D (msgid - mcl->baseid) / (8 * sizeof(access_vector_t)); I suppose this was the plan, but you inserted spaces in the wrong place. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDcI9uForvXbEpPzQRAmuuAJ9hdLuPHZYcCDe0qGL3Bup9AU72RgCggQwu nYuIEnMYE1yRTfUPTrap8Ew= =OWHF -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--