From owner-freebsd-current@FreeBSD.ORG Tue May 22 20:13:50 2007 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DCDE616A46C for ; Tue, 22 May 2007 20:13:50 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 7399513C45D for ; Tue, 22 May 2007 20:13:50 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 08ED448801; Tue, 22 May 2007 22:13:49 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0BDB9456AB; Tue, 22 May 2007 22:13:44 +0200 (CEST) Date: Tue, 22 May 2007 22:13:36 +0200 From: Pawel Jakub Dawidek To: Dag-Erling Sm??rgrav Message-ID: <20070522201336.GA4201@garage.freebsd.pl> References: <46534301.10005@FreeBSD.org> <864pm4zkre.fsf@dwp.des.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline In-Reply-To: <864pm4zkre.fsf@dwp.des.no> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: Joe Marcus Clarke , "current@freebsd.org" Subject: Re: [Fwd: Serious problem with mount(8)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 20:13:51 -0000 --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 22, 2007 at 10:05:57PM +0200, Dag-Erling Sm??rgrav wrote: > Joe Marcus Clarke writes: > > I really don't know why I didn't notice this before, but when mount was > > converted to use the pidfile(3) API three months ago, the behavior of > > mount(8) changed with regard to restarting mountd. A pidfile client > > cannot use pidfile_open(3) as this will truncate the pidfile. The > > result is that mount reads in a PID of 0, and when it tries to send a > > SIGHUP to this PID, it kills itself. Consequently, this is breaking the > > ports Tinderbox. > > > > I suppose we could revert to the previous behavior, but use flopen() to > > test if the file is actually locked. Maybe something like this: > > > > http://www.marcuscom.com/downloads/mount.c.diff >=20 > Better yet, extend the pidfile API with a function which reads the > contents of a PID file and also checks whether it's locked. That would be useful also for pkill(1). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGU07wForvXbEpPzQRApoEAKDYPRk6Rih7K7kn8JsFzhp9zquXaACg6Un9 CGw9Z6QwQqR0fZEdL35k+mw= =Hrmo -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--