From nobody Mon Sep 29 19:11:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cb9mG36KQz68hLW; Mon, 29 Sep 2025 19:11:58 +0000 (UTC) (envelope-from christos@freebsd.org) Received: from margiolis.net (mail.margiolis.net [95.179.159.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cb9mF4lnWz3mxS; Mon, 29 Sep 2025 19:11:57 +0000 (UTC) (envelope-from christos@freebsd.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=karaMF1Ao+K3 RdVvsC78ZXLyaHaVnPHtIyUjVb6dE6s=; h=in-reply-to:references:subject:cc: to:from:date; d=margiolis.net; b=aHPPL/7euHw+kSJSbUIjFiY6QUfFHCgfMbFW5 JgDi+a8v5dK48TNaExzJaNS12AR7028bK+O41XNME7vt+7iilvOZEKlxlSqN9ejk2976/8 JlhL+7UJsluuzgFMgcYtY0gQjAnEJABZpUYsJy+WfcUfvCwthO6XoxTBlOWcr4ZQ= Received: from localhost (public-gprs552949.centertel.pl [37.225.23.54]) by margiolis.net (OpenSMTPD) with ESMTPSA id c70789a8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 29 Sep 2025 13:11:54 -0600 (MDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 29 Sep 2025 21:11:53 +0200 Message-Id: From: "Christos Margiolis" To: "Peter Jeremy" Cc: , , Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base X-Mailer: aerc 0.21.0 References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:95.179.144.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cb9mF4lnWz3mxS On Mon Sep 29, 2025 at 11:58 AM CEST, Peter Jeremy wrote: > On 2025-Sep-28 09:58:53 +0000, Christos Margiolis = wrote: >>The branch main has been updated by christos: >> >>URL: https://cgit.FreeBSD.org/src/commit/?id=3D9cab9fde5edad9b409dd2317a2= aec7815e6d6bed >> >>commit 9cab9fde5edad9b409dd2317a2aec7815e6d6bed >>Author: Christos Margiolis >>AuthorDate: 2025-09-28 09:56:52 +0000 >>Commit: Christos Margiolis >>CommitDate: 2025-09-28 09:56:52 +0000 >> >> virtual_oss: Port to base > > This fails to compile if "WITHOUT_BLUETOOTH=3Dyes" is specified (see belo= w) > because bluetooth.h isn't available (as expected). It looks like > virtual_oss isn't taking that option into account when working out what > to compile. > > # Meta data file /usr/obj/usr/src/arm64.aarch64/usr.sbin/virtual_oss/virt= ual_bt_speaker/bt_speaker.pieo.meta > CMD cc -target aarch64-unknown-freebsd16.0 --sysroot=3D/usr/obj/usr/src/a= rm64.aarch64/tmp -B/usr/obj/usr/src/arm64.aarch64/tmp/usr/bin -fpie -DPIC = -O2 -pipe -fno-common -I/usr/src/usr.sbin/virtual_oss/virtual_oss -I/usr/= src/lib/virtual_oss/bt -mcpu=3Dcortex-a53 -fPIE -g -gz=3Dzlib -std=3Dgnu17= -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror = -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissin= g-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wsw= itch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-ex= terns -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variab= le-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-u= nused-const-variable -Wno-error=3Dunused-but-set-parameter -Wno-error=3Dcas= t-function-type-mismatch -Qunused-arguments -c /usr/src/usr.sbin/virt= ual_oss/virtual_bt_speaker/bt_speaker.c -o bt_speaker.pieo > CMD=20 > CWD /usr/obj/usr/src/arm64.aarch64/usr.sbin/virtual_oss/virtual_bt_speake= r > TARGET bt_speaker.pieo > OODATE /usr/src/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.c > -- command output -- > /usr/src/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.c:45:10: fata= l error: 'bluetooth.h' file not found > 45 | #include > | ^~~~~~~~~~~~~ > 1 error generated. > > *** Error code 1 I haven't had time to test yet, but I will try tomorrow. Does the build work if you build virtual_bt_speaker(8) conditionally in the Makefile (i.e., usr.sbin/virtual_oss/Makefile)? Christos