From owner-svn-src-head@freebsd.org Tue Sep 3 14:34:39 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1E319C9A11 for ; Tue, 3 Sep 2019 14:34:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N8bx6q8kz3yZ8 for ; Tue, 3 Sep 2019 14:34:37 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x844.google.com with SMTP id r15so14513857qtn.12 for ; Tue, 03 Sep 2019 07:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kYx3tlskOyNRxjjv4taHfNKh6ebMYLw839uYLWFOjes=; b=O+tvicKiFtL/GS3jliOzRyWVYlVQ5JV815kSdB2p5rNXCS0bXW90CPkVOKoZNvHl7G JUAhHUYjal4fIUAUN7EjwcLyJbmGLo2bB3QNJ13XohuXCySXpjSle+uMT+JMbredZgxw od08Q5J6ICo0yfyBlCxq5ktd04BFLN089B0c2kQuzkIeKg9ptB6fC/5PBKs6Ed9JlxOF k++ws1do797PlskURWpLP3vMFGYOn5cpitNWsi1Xdd++DPZP1xTrEKWrpLs6KaTGZDb4 TfpqSEQQLfq+r67JwQaeh0TfyBYg/GxVBwBtn4t1uGVTnMEde1lKExQCn7OwfKda8H2m UG9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kYx3tlskOyNRxjjv4taHfNKh6ebMYLw839uYLWFOjes=; b=YIvVg1TGZXPa6rTfq8b9BFqmhzTvgyimvCux5bNXcPCBYqFl7fmnpBS44Dv8mLL4Yz sRzoKK+WSxzndZJGyy/LPsoYCfszbvzWtJoW8BZ71MR5vwrTSq9B8irIhnqL6F0FlAFS FLPwYzyPqKsmz3LubID4IXqK3CJnzerkAyqq/J8dlG7oKqfoec2kHApWBsI/c9ijk08+ cdCq5esnH+j6Jj9caRAPZzrcAUh9+WHDZK76g3aNRck6ylzeCN4q0ikk/SQ3pQJYjkoc ej1l1uKrJUkO4aRlu9r7vVmdgJRdeNF+5DChc4AqLW0bAillDilIpO/AHbgXKBvKrKB/ dbVQ== X-Gm-Message-State: APjAAAXcmfKDDG/LEV6bQAZN71mPcOwPJUMpjEVBmi3ZH3q2jZBI1Lpm ml91rf2HqqxZzLKlDO/eOHpBRQ== X-Google-Smtp-Source: APXvYqx7fab7uG0F3wav1+rUam8hklc+T42UMBUglzjkjO4s3SFh38yyVr/v4vI1CY22kBLm5UhPvQ== X-Received: by 2002:aed:2f42:: with SMTP id l60mr2537789qtd.315.1567521276753; Tue, 03 Sep 2019 07:34:36 -0700 (PDT) Received: from mutt-hbsd ([63.88.83.108]) by smtp.gmail.com with ESMTPSA id t199sm8682282qke.36.2019.09.03.07.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 07:34:36 -0700 (PDT) Date: Tue, 3 Sep 2019 10:34:35 -0400 From: Shawn Webb To: Justin Hibbits Cc: Brooks Davis , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903143435.27atd53bvyj57sxh@mutt-hbsd> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> <20190903114740.gbzkeffdce3mkee2@mutt-hbsd> <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> <20190903093227.08bfdd8f@ralga.knownspace> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ci3vhogmgid7kxkw" Content-Disposition: inline In-Reply-To: <20190903093227.08bfdd8f@ralga.knownspace> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 46N8bx6q8kz3yZ8 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=O+tvicKi; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::844 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.59 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-0.98)[-0.975,0]; RCVD_IN_DNSWL_NONE(0.00)[4.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.51)[ip: (2.60), ipnet: 2607:f8b0::/32(-2.81), asn: 15169(-2.30), country: US(-0.05)] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 14:34:39 -0000 --ci3vhogmgid7kxkw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 09:32:27AM -0500, Justin Hibbits wrote: > On Tue, 3 Sep 2019 10:20:35 -0400 > Shawn Webb wrote: >=20 > > On Tue, Sep 03, 2019 at 07:47:40AM -0400, Shawn Webb wrote: > > > On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote: =20 > > > > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: =20 > > > > > Hey Mateusz, > > > > >=20 > > > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: = =20 > > > > > > Author: mjg > > > > > > Date: Tue Sep 3 04:16:30 2019 > > > > > > New Revision: 351729 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > > > >=20 > > > > > > Log: > > > > > > Add sysctlbyname system call > > > > > > =20 > > > > > > Previously userspace would issue one syscall to resolve the > > > > > > sysctl and then another one to actually use it. Do it all in > > > > > > one trip.=20 > > > > > > Fallback is provided in case newer libc happens to be > > > > > > running on an older kernel. > > > > > > =20 > > > > > > Submitted by: Pawel Biernacki > > > > > > Reported by: kib, brooks > > > > > > Differential Revision: > > > > > > https://reviews.freebsd.org/D17282 > > > > > >=20 > > > > > > Modified: =20 > > > > > ... snip ... =20 > > > > > > head/sys/sys/param.h =20 > > > > >=20 > > > > > ... snip ... > > > > > =20 > > > > > >=20 > > > > > > Modified: head/sys/sys/param.h > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 > > > > > > 2019 (r351728) +++ head/sys/sys/param.h Tue Sep > > > > > > 3 04:16:30 2019 (r351729) @@ -60,7 +60,7 @@ > > > > > > * in the range 5 to 9. > > > > > > */ > > > > > > #undef __FreeBSD_version > > > > > > -#define __FreeBSD_version 1300044 /* Master, > > > > > > propagated to newvers */ +#define __FreeBSD_version > > > > > > 1300045 /* Master, propagated to newvers */ =20 > > > > >=20 > > > > > To an outsider, it seems that __FreeBSD_version tends to be > > > > > bumped in a separate commit. Am I remembering that right? =20 > > > >=20 > > > > It should be bumped in the same commit, but people forget or the > > > > bump they have in their review turns into a no-op because someone > > > > else does a bump in the interim (the latter has bit me several > > > > times). =20 > > >=20 > > > Interesting. Thanks for the clarification! =20 > >=20 > > One thought for making the version bump a seperate commit is if the > > original commit needed to be reverted, the commit can be reverted > > wholesale (well, from the perspective of __FreeBSD_version) without > > worry of accidentally decrementing the version number to a prior > > value. > >=20 > > That's my "need-more-caffeine" verbose way of saying "separating the > > version bump from the actual work allows for easier maintenance of the > > version number, helping ensure an always-increasing number." > >=20 > > Sorry if I sound dry here. My ten-month-old puppy is tiring me out way > > faster than I can tire him out. > >=20 > > Thanks, > >=20 >=20 > I always thought convention was separate commits to ease MFCs. The few > times I've bumped __FreeBSD_version I've done it explicitly as a > followup commit for that reason. Guess I now know better :) I should also note that I'm looking at this from an outsider's perspective, which may not reflect the same perspective as an insider's. :) --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --ci3vhogmgid7kxkw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl1uefYACgkQ/y5nonf4 4fqU1w//TUBQ3MDeNWWBhcXwreEtxgQ3EBCMV3wzU+HgdPJgAcDTIDG/B97WGuRn vk6s+92MDmrFU89IxdnLAg9YuvnuHQaSzj1G+P1yLkivuqn+gzydSm2krp/1cLx2 CmCN5JCR/J4TcDclnRyUtM7p/BsXUMTt4pPBDnDwV1dlIC57eaGwZrH3cxtjf6Pl BncjZ/FSJualpT/k7FHpaagoVy8wKkV4/IkT2uwsD92Fl2FE7AT1GByC3dkjV+oi nUSDShXhKL5O8yjsXBlZDq1PBgo3sRHPZMmR15esdFFrXeBe+Hv4p/Kbl+o6R55Z l0gVIANgJTwuFy/y1MLLhW2Q+BcBeL2Py/3ok5QR5fRzUIMtTuBQiArQd6mAH74w f3e7S2917hGXsElNfXH69etJ/gt41rMMlL/voVHRHT7WHyMzEt4uv9IzYToIXxhL R7ROkCscKS2s5JZ9LzK7zQNRLed0fAXKKMTBEHf0FpELYkSk6JUNEcilliOHRiuD EGXhiCWdL0PflrNhWiw46XXn5cnCHs4GG5YGx5YLOUoc/umr0QFTZvKVUSrH6whW cCjPqyu0IvBlvQLWGgL8I61oG9X9FctaMVOv51ZV9o8WqmnYxDP8slznH52MCGhK c3oCMj4XcKKZU6HFbUhbfuBdzWwfPSzrmMKj5Irojvmu++aqtw0= =gDYP -----END PGP SIGNATURE----- --ci3vhogmgid7kxkw--