From owner-svn-src-head@FreeBSD.ORG Thu Nov 29 13:04:57 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 420CEC66; Thu, 29 Nov 2012 13:04:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id C36F38FC08; Thu, 29 Nov 2012 13:04:56 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qATD4n66063652; Thu, 29 Nov 2012 15:04:49 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qATD4n66063652 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qATD4n4G063651; Thu, 29 Nov 2012 15:04:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Nov 2012 15:04:49 +0200 From: Konstantin Belousov To: Eitan Adler Subject: Re: svn commit: r243665 - head/sbin/dump Message-ID: <20121129130449.GH3013@kib.kiev.ua> References: <201211290516.qAT5GoT5098709@svn.freebsd.org> <20121129120147.GE3013@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7e8BFhNxqpjiNKz7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 13:04:57 -0000 --7e8BFhNxqpjiNKz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 29, 2012 at 07:45:12AM -0500, Eitan Adler wrote: > On 29 November 2012 07:01, Konstantin Belousov wrot= e: > > On Thu, Nov 29, 2012 at 05:16:50AM +0000, Eitan Adler wrote: > >> Author: eadler > >> Date: Thu Nov 29 05:16:50 2012 > >> New Revision: 243665 > >> URL: http://svnweb.freebsd.org/changeset/base/243665 > >> > >> Log: > >> Mark non-returning function as such > >> > >> PR: bin/172978 > >> Approved by: cperciva > >> MFC after: 3 days > >> > >> Modified: > >> head/sbin/dump/dump.h > >> > >> Modified: head/sbin/dump/dump.h > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sbin/dump/dump.h Thu Nov 29 03:48:39 2012 (r243664) > >> +++ head/sbin/dump/dump.h Thu Nov 29 05:16:50 2012 (r243665) > >> @@ -121,7 +121,7 @@ void trewind(void); > >> void writerec(char *dp, int isspcl); > >> > >> void Exit(int status) __dead2; > >> -void dumpabort(int signo); > >> +void dumpabort(int signo) __dead2; > >> void dump_getfstab(void); > >> > >> char *rawname(char *cp); > > What is the goal of this change ? >=20 > It fixes some static analyzer warnings. This cannot be a reason to cripple the code. --7e8BFhNxqpjiNKz7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQt11vAAoJEJDCuSvBvK1BOtoP+wUojm+INQ2WCWJIJicFBe6h lRw+a1cJw38Ww/4dAjytL1cQe7vdG9YgJf3MK3+n7ZVDjBRa+TtyZpsR97A6nI8B XHB+Ozl/qGagebrguoOoCy+IYcR04R6E/wC+Q2mxhko7HPzoXZQSUFh+hpkj0BFl xysz4IBHjfXL1kh8r2TPeuSBcd6MQN/xWjmPZZFPIsHcwRAgsTQb+h0a9LrrUfp5 C/3CZPopsuICbwMuLgWiPcliudU0/fdivzoL6snUEzg0EV0g+32w0rPfUU2Jsfin VjEinuYT7M6NZsNv2Scl+xLxaOSQpNKcnz0hWBMFARuLgTVBHt3fBpa6CqKiL2Yy TWUAGdTu9YwbjdjsCJ3eLEe+6n5TijbepK5OvQGYqNRZz3/se0C5cRpYF6318TFD 3o1kXK/eu+aJ93SaJkIbkZmbX6TNXMJRyDpQ+Ik2g0pt4NKOmKcWt9uOySlRTbVx UN8BHU9DxhJz4lR6z/YwlBN4Uu4mmmMF2QsRLcJ7wV4b4qbo6zhd8XFEkNcHESVj JTZlq9ktXAKUd4DnWBiQuZmSn4UbKAWW3f1pjHyDBAcWnoM/y3FnaxgpqoIBStE4 VCF0PfuUoMeOcCZEJohsfsM5BgApq62OOmseisOSzgBWVTeGzvLNvdgMEYe9xdZF elq7gjruUC2jMGPzcOTA =aaDE -----END PGP SIGNATURE----- --7e8BFhNxqpjiNKz7--