From nobody Thu Jun 6 21:33:04 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VwHdM1wzfz5N491 for ; Thu, 06 Jun 2024 21:33:43 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VwHdM01qvz41mC for ; Thu, 6 Jun 2024 21:33:43 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717709623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94NqsJxpCH2I+huAGS0GlrFEAdvaOr6d8asJA5zlwec=; b=keYANg3bGoLALgF8isd8uD1OJuZigY7Uz+thKZU5YVUsF26zEr5pTtuJijhd1B0TzXOHwG JBUyOuHax2wUJ5F7quywITSh1Yvjqc0Irr0xRrI/shxskFAy7mIRO3K5Irqdb0l9FsPphL ivZxkGX2QvutVJE5LswbcMnFHQ/ZQa74ntV2QVZxr/NQPpFwYq/7cBFIdcvP3fgkmVTH68 YXB+sCovZaOR36ZdXzi+SmURXp25pcZfDx9FT8KbMwIUvsL+FAWr8GH77XFjsILBdQB2JC hmCS8JKToP2orMZrG6I/orG0VJ9b/9KfpMkum+VltOwxN2ROPwqb0SoY7bRj7w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717709623; a=rsa-sha256; cv=none; b=lRqs7oqZ1T0ykcDao41ek3U5S17tmsld1B6hn50Tiu4oEc51GEXuYSufQ8fIxed47vCcKX Kg/tW/JqSV9N7kfDJkYfZTHCNcZSFuxVsrsUONwXMhFiR7nDdS656g+VeNnRoGwL5YEc8v /jVh2xh2xM3WBaVC7K6it2m38nIQbP5/IB4V2O9fnzw6gD2gRlRAkX+AvVmzR78gEKDZ5F jv5miF6b2H9hpi8qdEVADhlbUvesCJdf78kDQ0gjisBTPoy9CPWborCEmCAJmBcjce3lML U9vI4y0CnF9TyWKVtk/OPDI0/g6traDHFtbbDE9/PL9DbcCwvQTyqE6wfrNHVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717709623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94NqsJxpCH2I+huAGS0GlrFEAdvaOr6d8asJA5zlwec=; b=A0O625DBh0t11xCswc1DlE/Y9ZorcOvfe9xatONbzuEU6ggErqTK+r9uz2c4MpGcoyxG2f V/wM9zLHfljSBoxnF57MWhwQslzuzaVsPreX2pZAYglWOQOhyr3iPKdxyDWtWarb1ZJU8x 8rpNoNUBiHMigbORv2lvwxq0B1IrUyRvnFG2fmMJ4t5djh8arQrmNoLSQ8F85IgSmLCAw5 110F3RVcgbl5kXjsM6iYtMVvOkygnK/Y5E3V9y5pzGgoQJaBadyWdAvMjSGbKELf0Hk+bj uC2oDPAqmpfCiHkWaz5QwXjTbXd8BKNIhufqYuqQxfNNhH4y1+1MxrdPlVm2IA== Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VwHdL6dTBz1b4V for ; Thu, 6 Jun 2024 21:33:42 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a68b41ef3f6so150757366b.1 for ; Thu, 06 Jun 2024 14:33:42 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUfyIw/w+3EXCPVH2cWr+bbgI8cAQjRjbYiN0344aVC0E0UIFWwqzWW8BcxF08ux9GeU6e004+21n4IMq54AEqYCLTBwuhWefT82IHT1364rciU X-Gm-Message-State: AOJu0YxQYGOoqbcubM1+uaWyj6Q5crsCtJs7u8zQQkdkte8rhg4DRY4I 8iWPqbmR0kfFnOmneycd91rvHpt2eTTrGfoCLAUa00cWORzPRPzGI2gER3XItUQI/V3CmTFRyEI 0kngi+OjFv3qOMKyi74Y6b1RrGWmVCvEaKxAdGQ== X-Google-Smtp-Source: AGHT+IFOUdHBss0v70mG0Q4Vnzod4miQBSLs42oLPLNimnPIsNiNbw553xgJ118O1LfwJrSDMaTd4zKijCl4uIV3ctI= X-Received: by 2002:a17:906:ad87:b0:a68:ec11:4561 with SMTP id a640c23a62f3a-a6cdc0e3a63mr46704166b.76.1717709621574; Thu, 06 Jun 2024 14:33:41 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202405191726.44JHQM14064613@gitrepo.freebsd.org> <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org> In-Reply-To: <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org> From: Po-Chuan Hsieh Date: Fri, 7 Jun 2024 05:33:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b9a3602bb3da - main - devel/py-pyproject_hooks: Update to 1.1.0 To: Charlie Li Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, python@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d26268061a3f6f08" --000000000000d26268061a3f6f08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Charlie Li wro= te: > Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177= a95a1233afc > > > > commit b9a3602bb3da661da313a970d4177a95a1233afc > > Author: Po-Chuan Hsieh > > AuthorDate: 2024-05-19 16:17:56 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2024-05-19 17:15:43 +0000 > > > > devel/py-pyproject_hooks: Update to 1.1.0 > > > > Changes: > https://github.com/pypa/pyproject-hooks/blob/main/docs/changelog.rst > > > https://pyproject-hooks.readthedocs.io/en/latest/changelog.html > This is causing all setuptools builds under PEP-517 even upstream to fail= : > https://github.com/pypa/pyproject-hooks/issues/192 > https://github.com/pypa/setuptools/issues/4333 > > So far the only fallout here is with devel/py-setuptools58 since it uses > PEP-517 to build, but may want to consider rolling back pyproject_hooks > for now in case it takes a bit for upstream to figure out. > > -- > Charlie Li > ...nope, still don't have an exit line. > > IMHO, we do n=C3=B3t need to do anything right now as py-setuptools58 is no= t used by anything. It means we do not need to revert py-pyproject_hooks. Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptools58 are needed in our ports tree. Since we could build almost every python port with pep517 (with minor fixes for the case in its name), we should always use devel/py-setuptools with correct version requirement rather than PY_SETUPTOOLS. In my case, there are 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddistutils which are intentional for simplicity. We should encourage people to convert their ports to pep517 build. And we should preserve PY_SETUPTOOLS for conditional dependency on py-setuptools for Python 3.12+. Best regards, sunpoet --000000000000d26268061a3f6f08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Ch= arlie Li <vishw= in@freebsd.org> wrote:
Po-Chuan Hsieh wrote:
> The branch main has been updated by sunpoet:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177a95a1233= afc
>
> commit b9a3602bb3da661da313a970d4177a95a1233afc
> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2024-05-19 16:17:56 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2024-05-19 17:15:43 +0000
>
>=C2=A0 =C2=A0 =C2=A0 devel/py-pyproject_hooks: Update to 1.1.0
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://github.com/pypa/pyproject-hooks/blob/m= ain/docs/changelog.rst
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 https://pyproject-hooks.readth= edocs.io/en/latest/changelog.html
This is causing all setuptools builds under PEP-517 even upstream to fail:<= br> https://github.com/pypa/pyproject-hooks/issues/192=
https://github.com/pypa/setuptools/issues/4333

So far the only fallout here is with devel/py-setuptools58 since it uses PEP-517 to build, but may want to consider rolling back pyproject_hooks for now in case it takes a bit for upstream to figure out.

--
Charlie Li
...nope, still don't have an exit line.


IMHO, we do n=C3=B3t need to do anythi= ng right now as py-setuptools58 is not used by=C2=A0anything.
It = means we do not need to revert py-pyproject_hooks.

Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptoo= ls58 are needed in our ports tree.
Since we could build almost ev= ery python port with=C2=A0pep517 (with minor fixes for the case in its name= ), we should always use devel/py-setuptools with=C2=A0correct=C2=A0version = requirement rather=C2=A0than PY_SETUPTOOLS.
In my case, there are= 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddi= stutils which are intentional for simplicity.

We s= hould encourage people to convert their ports to pep517 build.
An= d we should preserve PY_SETUPTOOLS for conditional dependency=C2=A0on py-se= tuptools for Python 3.12+.

Best regards,
sunpoet
--000000000000d26268061a3f6f08--