From owner-freebsd-ports  Sun Oct 22  8:53:31 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4652137B479; Sun, 22 Oct 2000 08:53:23 -0700 (PDT)
Received: (from freebsd@localhost)
	by gndrsh.dnsmgr.net (8.9.3/8.9.3) id IAA33410;
	Sun, 22 Oct 2000 08:53:07 -0700 (PDT)
	(envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <200010221553.IAA33410@gndrsh.dnsmgr.net>
Subject: Re: Supporting INCS on 3-STABLE
In-Reply-To: <86puktyihz.wl@archon.local.idaemons.org> from Akinori MUSHA at "Oct 22, 2000 06:47:04 am"
To: knu@idaemons.org (Akinori MUSHA)
Date: Sun, 22 Oct 2000 08:53:07 -0700 (PDT)
Cc: freebsd-stable@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG,
	asami@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> I was noticed that my textproc/expat port doesn't install header files
> automatically on 3-STABLE because 3-STABLE's bsd.lib.mk doesn't
> recognize INCS macro.

Your textproc/expat port is abusing an interface that is not public,
please remove the dependency of INCS from your port.

> Now, can we merge the INCS support to 3-STABLE?  I'm not saying that
> we should modify src/lib/*/Makefile so they use INCS macro, but just
> make bsd.lib.mk support the macro and leave src/lib/*/Makefile for
> safety.

No, please don't.  It was bad enough that someone took expermintal
work from -current into 4-STABLE directly against the authors recomendations.

> I found only one file defines INCS though the variable is not actually
> used, and we can remove the definition.

Are you sure it is not used?  What happens during a make install in
src/lib/libcom_err?  Don't com_err.h and com_right.h get installed
by the backcall to _includeinstall:?

> If no one opposes and the merging is done, I hope bsd.lib.mk will be
> included in the ports upgrade kits for 3.x.

I oppose the addition of _includeinstall: into the 3.x tree.

> 
> Opinions?
> 
> 
> Index: src/lib/libcom_err/Makefile
> ===================================================================
> RCS file: /home/ncvs/src/lib/libcom_err/Makefile,v
> retrieving revision 1.8.2.3
> diff -u -r1.8.2.3 Makefile
> --- src/lib/libcom_err/Makefile	2000/07/07 04:55:07	1.8.2.3
> +++ src/lib/libcom_err/Makefile	2000/10/21 20:50:30
> @@ -2,7 +2,6 @@
>  
>  LIB=	com_err
>  SRCS=	com_err.c error.c
> -INCS=	${COM_ERRDIR}/com_err.h ${COM_ERRDIR}/com_right.h
>  MAN3=	com_err.3
>  COM_ERRDIR=	${.CURDIR}/../../contrib/com_err
>  CFLAGS+=	-I${COM_ERRDIR}
> Index: src/share/mk/bsd.lib.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v
> retrieving revision 1.84.2.2
> diff -u -r1.84.2.2 bsd.lib.mk
> --- src/share/mk/bsd.lib.mk	1999/08/29 16:47:43	1.84.2.2
> +++ src/share/mk/bsd.lib.mk	2000/10/21 20:48:46
> @@ -259,7 +259,17 @@
>  
>  .if !target(install)
>  .if !target(beforeinstall)
> -beforeinstall:
> +beforeinstall: _includeinstall
> +.endif
> +
> +_includeinstall:
> +.if defined(INCS)
> +.for header in ${INCS}
> +	cd ${.CURDIR} && \
> +	${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m ${INCMODE} \
> +		${header} ${DESTDIR}${INCDIR}
> +
> +.endfor
>  .endif
>  
>  .if defined(PRECIOUSLIB)
> 
> 
> -- 
>                            /
>                           /__  __
>                          / )  )  ) )  /    and.or.jp / ruby-lang.org
> Akinori -Aki- MUSHA aka / (_ /  ( (__(  @ idaemons.org / FreeBSD.org
> 
> "We're only at home when we're on the run, on the wing, on the fly"
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-stable" in the body of the message
> 


-- 
Rod Grimes - KD7CAX @ CN85sl - (RWG25)               rgrimes@gndrsh.dnsmgr.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message