Date: Tue, 18 Mar 2008 11:52:20 GMT From: Andrew Kolchoogin <andrew@rinet.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/121826: security/openssh-portable doesn't honor LOCALBASE setting when built with LDAP public key support Message-ID: <200803181152.m2IBqKAe009504@www.freebsd.org> Resent-Message-ID: <200803181200.m2IC02s7068350@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 121826
>Category: ports
>Synopsis: security/openssh-portable doesn't honor LOCALBASE setting when built with LDAP public key support
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 18 12:00:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Andrew Kolchoogin
>Release: FreeBSD 7.0-RELEASE
>Organization:
JSC "Transservice Communication"
>Environment:
FreeBSD host.domain.tld 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Fri Mar 14 16:26:31 MSK 2008 user@host.domain.tld:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
There are unnecessarily hard-coded path to OpenLDAP libraries exist in Makefile. Why don't just use standard bsd.port.mk-style path references?
>How-To-Repeat:
Just set LOCALBASE to something different from '/usr/local' and try to build port with 'WITH_LPK' option enabled.
>Fix:
--- a/security/openssh-portable/Makefile Thu Mar 13 21:21:52 2008 +0300
+++ b/security/openssh-portable/Makefile Tue Mar 18 14:51:12 2008 +0300
@@ -150,8 +150,8 @@ PATCHFILES+= openssh-lpk-4.6p1-0.3.9.pa
PATCHFILES+= openssh-lpk-4.6p1-0.3.9.patch
USE_OPENLDAP= yes
CPPFLAGS+= "-I${LOCALBASE}/include -DWITH_LDAP_PUBKEY"
-CONFIGURE_ARGS+= --with-libs='-lldap' --with-ldflags='-L/usr/local/lib' \
- --with-cppflags='-I/usr/local/include -DWITH_LDAP_PUBKEY'
+CONFIGURE_ARGS+= --with-libs='-lldap' --with-ldflags='-L${LOCALBASE}/lib' \
+ --with-cppflags='-I${LOCALBASE}/include -DWITH_LDAP_PUBKEY'
.endif
.if defined(WITH_OVERWRITE_BASE)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803181152.m2IBqKAe009504>