From owner-svn-ports-head@freebsd.org  Mon Apr 24 21:55:33 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA2EBD4E607;
 Mon, 24 Apr 2017 21:55:33 +0000 (UTC)
 (envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6BF8FBC2;
 Mon, 24 Apr 2017 21:55:32 +0000 (UTC)
 (envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
 by alchemy.franken.de (8.15.2/8.15.2/ALCHEMY.FRANKEN.DE) with ESMTPS id
 v3OLtIo8026419
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 24 Apr 2017 23:55:18 +0200 (CEST)
 (envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
 by alchemy.franken.de (8.15.2/8.15.2/Submit) id v3OLtIP4026418;
 Mon, 24 Apr 2017 23:55:18 +0200 (CEST) (envelope-from marius)
Date: Mon, 24 Apr 2017 23:55:18 +0200
From: Marius Strobl <marius@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r439345 - in head/sysutils/cdrdao: . files
Message-ID: <20170424215518.GC15359@alchemy.franken.de>
References: <201704242023.v3OKNN8q058653@repo.freebsd.org>
 <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 21:55:33 -0000

On Mon, Apr 24, 2017 at 03:37:29PM -0600, Adam Weinberger wrote:
> > On 24 Apr, 2017, at 14:23, Marius Strobl <marius@FreeBSD.org> wrote:
> > 
> > Author: marius
> > Date: Mon Apr 24 20:23:23 2017
> > New Revision: 439345
> > URL: https://svnweb.freebsd.org/changeset/ports/439345
> > 
> > Log:
> >  - Move the inclusion of bsd.port.pre.mk up slightly so ${UNAME} is also
> >    available in the gcdmaster slave port at the required point in time
> >    (it's unclear why this was no problem with the cdrdao port before). [1]
> 
> Because you didn't add the != until r439255. Using != is almost always a bad thing in a port Makefile.

No, the != in r439255 worked for sysutils/cdrdao, but not for its
sysutils/gcdmaster slave.

> Why aren't you using ${ARCH}?

Because ${ARCH} translates to `uname -p` and what's needed here is
the output of `uname -m`. Depending on the architecture FreeBSD is
running on, both outputs are the same or differ.

Marius