From owner-svn-src-all@freebsd.org Tue Dec 5 18:57:20 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D71A2E74CD8; Tue, 5 Dec 2017 18:57:20 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 69D4069079; Tue, 5 Dec 2017 18:57:20 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id MIP5eWa9HGvLHMIP6ekSJ7; Tue, 05 Dec 2017 11:57:18 -0700 X-Authority-Analysis: v=2.2 cv=a9pAzQaF c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=ocR9PWop10UA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=ndaoGXS1AAAA:8 a=XC3ynbMe0NH15Jm6wAsA:9 a=59NxDjTQvWqhdRGL:21 a=lKrUHsMZsg-uI1nw:21 a=QEXdDO2ut3YA:10 a=m8DlcCAFU8aXbRfX6yYA:9 a=qS2ixOb_dgTcq_rL:21 a=hAFxksFN1iF-jhSP:21 a=DfFShuTV8cL9fB38:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=pxhY87DP9d2VeQe4joPk:22 a=mFeOnlTyF09QQMGr2mMI:22 Received: from [25.81.45.55] (S0106d4ca6d8943b0.gv.shawcable.net [24.68.134.59]) by spqr.komquats.com (Postfix) with ESMTPSA id 88D73495; Tue, 5 Dec 2017 10:56:09 -0800 (PST) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r326554 - in head: . usr.bin/spongeusr.bin/sponge/tests usr.bin/tee Date: Tue, 5 Dec 2017 10:56:13 -0800 To: Eitan Adler , Eric Joyner CC: Devin Teske , Hans Petter Selasky , "rgrimes@freebsd.org" , "cem@freebsd.org" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <20171205185609.88D73495@spqr.komquats.com> X-CMAE-Envelope: MS4wfFjdY/G1c1pBaDVphzYDFDXUwZ55Kh876EyzZSu1Cy75aO4eg2SUwOIWqbFwS3nFG6VjHX4ljuovMk6xBA0ctbj81Tti1F3awa6aY6SiPtX6/DxF7Yg7 hUtxtfjF7lq06GzPFTbdY3Pam+Qan9e+Kuoi+Ec/yKiYrHm5reXLhohm+6MXNkOPxQIrw300DO3SB0fo5GUR0Is3+ELYDWPFoSqgnNzOrmXhqlNy2DKpwhL9 lYZ87B1AK5+kPMzHBbLGXyTCOp7kL1Mny1qLnTAclphAD+lEgxw43itIZK0pbDh89AHoZpGzk9RTzxb5NYKrElhF33jBhod6eN9XY1pB+lQfE64TmW2TJ0AY bJIszDjpveBaCT0+7d1+KD9wNEonu16pVpolXf9SjX0AhO5pI7S5S0lMYqay0kFOPRAR/5lN Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 18:57:20 -0000 Looks like it was disconnected from buildworld. I have a patch on my laptop= but I won't have internet connectivity for another hour. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. This old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Eitan Adler Sent: 05/12/2017 10:40 To: Eric Joyner Cc: Cy Schubert; Devin Teske; Hans Petter Selasky; rgrimes@freebsd.org; cem= @freebsd.org; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd= .org Subject: Re: svn commit: r326554 - in head: . usr.bin/spongeusr.bin/sponge/= tests usr.bin/tee I'm not near my commit box right now so someone will have to revert it. What's funny is that I ran a complete 'make buildworld buildkernel' last night with this patch. Will respond to the rest of the thread later On 5 December 2017 at 10:08, Eric Joyner wrote: > I got told by a co-worker that this broke buildworld. Can this commit get > reverted/have the cast fixed? > > - Eric (erj) > > > On Tue, Dec 5, 2017 at 9:50 AM Cy Schubert wro= te: >> >> Our sed already creates backup files "optionally" just as gsed does. Onl= y >> the syntax is different. No need to sponge sed, just sed -i '' (whereas = gsed >> is -i without the argument). >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> or >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 09:23 >> To: Cy Schubert >> Cc: Hans Petter Selasky; rgrimes@freebsd.org; cem@freebsd.org; Eitan >> Adler; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org >> >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> On Dec 5, 2017, at 8:29 AM, Cy Schubert wrote= : >> >> Why not update sed to create the backup file only if the suffix is given >> to -i, like gnu sed does. >> >> >> I suspect that would break countless scripts that test uname to determin= e >> how to use the -i flag of sed. >> -- >> Devin >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> or >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 07:35 >> To: Hans Petter Selasky >> Cc: rgrimes@freebsd.org; cem@freebsd.org; Eitan Adler; src-committers; >> svn-src-all@freebsd.org; svn-src-head@freebsd.org >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> > On Dec 5, 2017, at 5:00 AM, Hans Petter Selasky wrot= e: >> > >> >> On 12/05/17 13:58, Rodney W. Grimes wrote: >> >> Further more, why does freebsd need this in base? >> > >> > Hi, >> > >> > I think this is useful. It could replace the "-i " (intermediate) opti= on >> > for "sed" for example. It avoids creating temporary files when filteri= ng >> > files, right? >> > >> > --HPS >> > >> >> Wth is wrong with: >> >> data=3D$( sed -e '...' somefile ) && >> echo "$data" > somefile >> >> or >> >> set -e >> data=3D... >> echo "$data" > ... >> >> or >> >> exec 3<> $( ... ) >> EOF >> cat > ... <&3 >> >> or >> >> (I digress) >> >> Infinite variations, but the gist is that sponge looks to be trying to >> help sh(1)/similar when help is unneeded. >> >> Why buffer data into memory via fork-exec-pipe to sponge when you can >> buffer to native namespace without pipe to sponge? >> >> Am I missing something? Why do we need sponge(1)? >> -- >> Devin >> > --=20 Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams