From owner-svn-src-all@FreeBSD.ORG Mon Jan 12 16:12:49 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F13DB2E; Mon, 12 Jan 2015 16:12:49 +0000 (UTC) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6828510B; Mon, 12 Jan 2015 16:12:49 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id rl12so25939981iec.12; Mon, 12 Jan 2015 08:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ye7R0MabxHymeg+QnTZElOxVgAYS+8YpNkuahHp2Lmw=; b=fadmfrfffSq3y6fFj/2zt0b0llkpGfKB/sXMWQr16VvfY8ps65/1FWpUr73vNT2Bad PqAJF7WRgfVxCXXidLGDaEgRYAoU01ZznQbCGcj853KO9LeL/E2KrhPBFc4uhLMCUxcY ZTCUZNroa5NrZHWBdILFE6asE3XsLMwKMS7SwUnRJfbj4omrjdXLl35wHGNosubPr40O fxg5xC2I6HkO3GF4W7my4LxhJhjaviOCC+k8/JTQ8rEdvWYevbw2cTUK+KfrMB+N+Of7 5GqRJc+lFRoZisOElSPj+m8/J2WxoahwzIMzKG8TKYsJPwaKUe2iJtEMaXx6wbtqjigp 7Kzw== X-Received: by 10.50.7.34 with SMTP id g2mr16089595iga.36.1421079168625; Mon, 12 Jan 2015 08:12:48 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.71.228 with HTTP; Mon, 12 Jan 2015 08:12:18 -0800 (PST) In-Reply-To: <6173473.uE5Sr5nj0c@ralph.baldwin.cx> References: <201410100609.s9A690NU067686@svn.freebsd.org> <54AC6F4E.1000707@FreeBSD.org> <6173473.uE5Sr5nj0c@ralph.baldwin.cx> From: Bryan Venteicher Date: Mon, 12 Jan 2015 10:12:18 -0600 X-Google-Sender-Auth: FBDzLg6aVUDQOZBFWAXJ25vj0x0 Message-ID: Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "src-committers@freebsd.org" , John Nielsen , Bryan Venteicher , "svn-src-all@freebsd.org" , Bryan Drewery , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2015 16:12:49 -0000 On Mon, Jan 12, 2015 at 9:51 AM, John Baldwin wrote: > On Tuesday, January 06, 2015 07:07:11 PM Bryan Venteicher wrote: > > On Tue, Jan 6, 2015 at 5:27 PM, Bryan Drewery > wrote: > > > On 1/6/2015 4:00 PM, Bryan Venteicher wrote: > > > > On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen > > > > > > > > wrote: > > > > Bryan- > > > > > > > > On Oct 10, 2014, at 12:09 AM, Bryan Venteicher < > bryanv@freebsd.org > > > > > > > > > wrote: > > > > > Author: bryanv > > > > > Date: Fri Oct 10 06:08:59 2014 > > > > > New Revision: 272886 > > > > > URL: https://svnweb.freebsd.org/changeset/base/272886 > > > > > > > > > > Log: > > > > > Add context pointer and source address to the UDP tunnel > callback > > > > > > > > > > These are needed for the forthcoming vxlan implementation. The > > > > > > context > > > > > > > > pointer means we do not have to use a spare pointer field in > the > > > > > > inpcb, > > > > > > > > and the source address is required to populate vxlan's > forwarding > > > > > > table. > > > > > > > > While I highly doubt there is an out of tree consumer of the > UDP > > > > > tunneling callback, this change may be a difficult to > eventually > > > > > > MFC. > > > > > > > I noticed this comment while doing an MFC of vxlan to my local > tree. > > > > Do you think an MFC to 10-STABLE of this change (and vxlan > > > > generally) will be feasible? Is there precedent for ABI changes > like > > > > this being sanctioned? Could symbol versioning help? > > > > > > > > I'd like to get some consensus on whether this commit is OK to MFC. > With > > > > this commit, vxlan should be an easy to MFC. > > > > > > Breaking ABI will potentially hurt packages. FreeBSD builds packages > for > > > the oldest supported release on a branch. If you break ABI in 10.2 > while > > > we are building packages for 10.1 then any packages using these > > > interfaces may not work right or result in panics packages with kmods. > > > Please consider that. > > > > The only user visible change of this commit would be the addition of a > > field at the end of 'struct udpcb'. I don't think that is a problem, at > > least a similar change didn't prevent the MFC of UDP Lite. > > > > The kernel part of this changes the UDP tunneling functions which I guess > > there could be a 3rd party module out there, but I very highly doubt > that, > > based on how un-useful the previous interface was. > > Userland should not be impacted by this at all. (Nothing in userland cares > about udpcb's internals.) I think there was only ever one consumer for the > existing UDP tunneling code (bz@ knows what it is). I'm not sure where it > lives. > > The only in tree consumer is SCTP. > -- > John Baldwin > >