From owner-svn-src-all@FreeBSD.ORG Wed Feb 29 12:37:31 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9109A106564A; Wed, 29 Feb 2012 12:37:31 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 29B2B8FC21; Wed, 29 Feb 2012 12:37:29 +0000 (UTC) Received: by eaaf13 with SMTP id f13so346317eaa.13 for ; Wed, 29 Feb 2012 04:37:29 -0800 (PST) Received-SPF: pass (google.com: domain of to.my.trociny@gmail.com designates 10.14.202.65 as permitted sender) client-ip=10.14.202.65; Authentication-Results: mr.google.com; spf=pass (google.com: domain of to.my.trociny@gmail.com designates 10.14.202.65 as permitted sender) smtp.mail=to.my.trociny@gmail.com; dkim=pass header.i=to.my.trociny@gmail.com Received: from mr.google.com ([10.14.202.65]) by 10.14.202.65 with SMTP id c41mr64151eeo.79.1330519049132 (num_hops = 1); Wed, 29 Feb 2012 04:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=VEHFXFfXeEcW2EgmGi5tMggAwWXDi/UE7w5S8m6C+x0=; b=L6st7rAIwFHXGzB2QwLlaRQtoDHvNPvspsOwH8GTikmqqFGY7bw4Lx6VzykyzAUBRd TpzsetpZwlQTpQkrB5V3KmeScGy2rijkiC3NVH/ekhXajkf9eIogFUPi6gvigPr9opxB iKr5p4iC+OOid21kbuBd17WHe4Fv37tnvxSjM= Received: by 10.14.202.65 with SMTP id c41mr50372eeo.79.1330519048776; Wed, 29 Feb 2012 04:37:28 -0800 (PST) Received: from localhost ([94.27.39.186]) by mx.google.com with ESMTPS id o49sm82387863eeb.7.2012.02.29.04.37.26 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 29 Feb 2012 04:37:27 -0800 (PST) From: Mikolaj Golub To: "Robert N. M. Watson" Organization: TOA Ukraine References: <201202261425.q1QEPm9g069102@svn.freebsd.org> <20120227082811.GC1363@garage.freebsd.pl> <864nucd5jc.fsf@in138.ua3> <20120227092951.GB55074@deviant.kiev.zoral.com.ua> <4F4C7571.7010407@freebsd.org> <86zkc3bell.fsf@in138.ua3> <4F4D6AA4.9040208@freebsd.org> <86vcmqaxij.fsf@in138.ua3> <9557FCA0-7428-4794-8A27-9888F42974CA@freebsd.org> Sender: Mikolaj Golub Date: Wed, 29 Feb 2012 14:37:25 +0200 In-Reply-To: <9557FCA0-7428-4794-8A27-9888F42974CA@freebsd.org> (Robert N. M. Watson's message of "Wed, 29 Feb 2012 12:03:00 +0000") Message-ID: <86mx81byt6.fsf@in138.ua3> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Konstantin Belousov , Julian Elischer Subject: Re: svn commit: r232181 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Feb 2012 12:37:31 -0000 --=-=-= On Wed, 29 Feb 2012 12:03:00 +0000 Robert N. M. Watson wrote: RNMW> I think the monitoring aspect of the patch is fine. RNMW> The bit I was worried about was external umask changes. This can cause RNMW> race conditions for applications that manage their umask -- for RNMW> example, bsdtar, if I recall correctly. It's one thing to use a RNMW> debugger to force an application to change its umask -- the developer RNMW> needs to know they are changing application behaviour. But exposing a RNMW> feature that can lead to correct applications but incorrect results is RNMW> a risky thing to do, hence my objection. RNMW> I think given the other objections, it would be wise to remove write RNMW> access to process umasks, but retain read access for procstat (which is RNMW> quite useful, I agree). I still don't see why having a sysctl RW is worse than asking users to run something like in the attach when they need to change umask for another process, but ok, if people don't like RW I will remove it. -- Mikolaj Golub --=-=-=--